Safer remove check constraint #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report Results
3 empty files skipped. |
marcelofern
force-pushed
the
safer-remove-check-constraint
branch
from
ed49fe5 to
d9a318a
Compare
marcelofern
force-pushed
the
safer-remove-check-constraint
branch
from
d9a318a to
0f46299
Compare
s-cooper18
approved these changes
Jan 13, 2025
In order to show the best output to sqlmigrate, i.e., the one that shows the largest amount of DDL statements while omitting the introspective queries, we need to alter the "collect_default" value of this function when adding/removing check constraints This is a small clean up that will be used in the next commit.
Moves to the tests/example_app/models.py file so that it can be reused by future models that will need to have a check constraint that works in multiple versions of Django.
This operation is the counterpoise of SaferAddCheckConstraint. It allows to remove a check constraint more safely (idempotently), and also allows for a safer reverse operation (adding the check constraint back again).
As per e2e14c3 this should avoid some potentially mistaken copy/paste.
marcelofern
force-pushed
the
safer-remove-check-constraint
branch
from
0f46299 to
d20d8cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to
SaferAddCheckConstraintbut does the reverse (-: