Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotools: Refactor --enable-apcu-rwlocks option to PHP_ARG_ENABLE #514

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

petk
Copy link
Contributor

@petk petk commented Sep 1, 2024

  • Instead of AC_ARG_ENABLE the PHP_ARG_ENABLE works in similar manner and outputs the 2nd argument as the check message. Result variable is the same (PHP_APCU_RWLOCKS). By default the option is enabled like before. The 4th argument sets whether the option is enabled, the 5th argument indicates that this is not direct extension related configuration option (build system internal handling stuff).
  • AC_CACHE_CHECK check refactored: Entire check moved inside the main "extension-enabled" if block, AS_VAR_IF used, redundant double Autoconf quotes reduced.
  • AC_MSG_FAILURE works the same as AC_MSG_ERROR except that it also outputs the "See config.log for details" message at the end in case of failure, directing the user where to check for possible failure reason.

- Instead of AC_ARG_ENABLE the PHP_ARG_ENABLE works in similar manner
  and outputs the 2nd argument as the check message. Result variable is
  the same (PHP_APCU_RWLOCKS). By default the option is enabled like
  before. The 4th argument sets whether the option is enabled, the 5th
  argument indicates that this is not direct extension related
  configuration option (build system internal handling stuff).
- AC_CACHE_CHECK check refactored: Entire check moved inside the main
  "extension-enabled" if block, AS_VAR_IF used, redundant double
  Autoconf quotes reduced.
- AC_MSG_FAILURE works the same as AC_MSG_ERROR except that it also
  outputs the "See config.log for details" message at the end in case of
  failure, directing the user where to check for possible failure
  reason.
@nikic nikic merged commit 2b299d6 into krakjoe:master Sep 2, 2024
25 checks passed
@petk petk deleted the patch-enable-apcu-rwlocks branch September 2, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants