Merge pull request openmrs#2230 from teleivo/TRUNK-5206

TRUNK-5206 Extract test strings exceeding property lenghts in variables

api/src/test/java/org/openmrs/validator/ConceptAttributeTypeValidatorTest.java

@@ -126,16 +126,13 @@ public void validate_shouldPassEditingConceptAttributeTypeName() {
 	@Test
 	public void validate_shouldFailValidationIfFieldLengthsAreNotCorrect() {
 
-		type
-		        .setName("too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text");
-		type
-		        .setDatatypeClassname("too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text");
-		type.setDescription(
-		    "too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text");
-		type
-		        .setPreferredHandlerClassname("too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text");
-		type.setRetireReason(
-		    "too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text");
+		final String stringOf256 = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
+		final String stringOf1025 = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
+		type.setName(stringOf256);
+		type.setDatatypeClassname(stringOf256);
+		type.setDescription(stringOf1025);
+		type.setPreferredHandlerClassname(stringOf256);
+		type.setRetireReason(stringOf256);
 
 		validator.validate(type, errors);
 

api/src/test/java/org/openmrs/validator/PersonNameValidatorTest.java

@@ -35,6 +35,12 @@
  */
 public class PersonNameValidatorTest extends BaseContextSensitiveTest {
 
+	private static String STRING_OF_50 = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
+
+	private static String STRING_OF_51 = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
+
+	private static String STRING_OF_256 = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
+
 	private PersonNameValidator validator;
 
 	private PersonName personName;
@@ -198,8 +204,7 @@ public void validate_shouldFailValidationIfPersonNamePrefixIsTooLong() {
 
 		personName.setGivenName("givenName");
 		personName.setFamilyName("familyName");
-		personName
-		        .setPrefix("123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"); // 100 characters long
+		personName.setPrefix(STRING_OF_51);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -238,8 +243,7 @@ public void validate_shouldPassValidationIfPersonNamePrefixIsLessThanMaxFieldLen
 	@Test
 	public void validate_shouldFailValidationIfPersonNameGivenNameIsTooLong() {
 
-		personName
-		        .setGivenName("123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"); // 100 characters long
+		personName.setGivenName(STRING_OF_51);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -252,7 +256,7 @@ public void validate_shouldFailValidationIfPersonNameGivenNameIsTooLong() {
 	@Test
 	public void validate_shouldPassValidationIfPersonNameGivenNameIsExactlyMaxLength() {
 
-		personName.setGivenName("abcdefghijabcdefghijabcdefghijabcdefghijabcdefghij"); // exactly 50 characters long
+		personName.setGivenName(STRING_OF_50);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -278,8 +282,7 @@ public void validate_shouldPassValidationIfPersonNameGivenNameIsLessThanMaxField
 	@Test
 	public void validate_shouldFailValidationIfPersonNameMiddleNameIsTooLong() {
 
-		personName
-		        .setMiddleName("123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"); // 100 characters long
+		personName.setMiddleName(STRING_OF_51);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -320,8 +323,7 @@ public void validate_shouldFailValidationIfPersonNameFamilyNamePrefixIsTooLong()
 
 		personName.setGivenName("givenName");
 		personName.setFamilyName("familyName");
-		personName
-		        .setFamilyNamePrefix("123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"); // 100 characters long
+		personName.setFamilyNamePrefix(STRING_OF_51);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -360,8 +362,7 @@ public void validate_shouldPassValidationIfPersonNameFamilyNamePrefixIsLessThanM
 	@Test
 	public void validate_shouldFailValidationIfPersonNameFamilyNameIsTooLong() {
 
-		personName
-		        .setFamilyName("123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"); // 100 characters long
+		personName.setFamilyName(STRING_OF_51);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -400,8 +401,7 @@ public void validate_shouldPassValidationIfPersonNameFamilyNameIsLessThanMaxFiel
 	@Test
 	public void validate_shouldFailValidationIfPersonNameFamilyName2IsTooLong() {
 
-		personName
-		        .setFamilyName2("123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"); // 100 characters long
+		personName.setFamilyName2(STRING_OF_51);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -442,8 +442,7 @@ public void validate_shouldFailValidationIfPersonNameFamilyNameSuffixIsTooLong()
 
 		personName.setGivenName("givenName");
 		personName.setFamilyName("familyName");
-		personName
-		        .setFamilyNameSuffix("123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"); // 100 characters long
+		personName.setFamilyNameSuffix(STRING_OF_51);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -456,7 +455,7 @@ public void validate_shouldFailValidationIfPersonNameFamilyNameSuffixIsTooLong()
 	@Test
 	public void validate_shouldPassValidationIfPersonNameFamilyNameSuffixIsExactlyMaxLength() {
 
-		personName.setFamilyNameSuffix("12345678901234567890123456789012345678901234567890"); // exactly 50 characters long
+		personName.setFamilyNameSuffix(STRING_OF_50);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -484,8 +483,7 @@ public void validate_shouldFailValidationIfPersonNameDegreeIsTooLong() {
 
 		personName.setGivenName("givenName");
 		personName.setFamilyName("familyName");
-		personName
-		        .setDegree("123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"); // 100 characters long
+		personName.setDegree(STRING_OF_51);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -498,7 +496,7 @@ public void validate_shouldFailValidationIfPersonNameDegreeIsTooLong() {
 	@Test
 	public void validate_shouldPassValidationIfPersonNameDegreeIsExactlyMaxLength() {
 
-		personName.setDegree("12345678901234567890123456789012345678901234567890"); // exactly 50 characters long
+		personName.setDegree(STRING_OF_50);
 
 		validator.validatePersonName(personName, errors, false, true);
 
@@ -709,17 +707,16 @@ public void validate_shouldPassValidationIfFieldLengthsAreCorrect() {
 	@Test
 	public void validate_shouldFailValidationIfFieldLengthsAreNotCorrect() {
 
-		personName.setPrefix("too long text too long text too long text too long text");
-		personName.setGivenName("too long text too long text too long text too long text");
-		personName.setMiddleName("too long text too long text too long text too long text");
-		personName.setFamilyName("too long text too long text too long text too long text");
-		personName.setFamilyNamePrefix("too long text too long text too long text too long text");
-		personName.setFamilyName("too long text too long text too long text too long text");
-		personName.setFamilyName2("too long text too long text too long text too long text");
-		personName.setFamilyNameSuffix("too long text too long text too long text too long text");
-		personName.setDegree("too long text too long text too long text too long text");
-		personName
-		        .setVoidReason("too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text too long text");
+		personName.setPrefix(STRING_OF_51);
+		personName.setGivenName(STRING_OF_51);
+		personName.setMiddleName(STRING_OF_51);
+		personName.setFamilyName(STRING_OF_51);
+		personName.setFamilyNamePrefix(STRING_OF_51);
+		personName.setFamilyName(STRING_OF_51);
+		personName.setFamilyName2(STRING_OF_51);
+		personName.setFamilyNameSuffix(STRING_OF_51);
+		personName.setDegree(STRING_OF_51);
+		personName.setVoidReason(STRING_OF_256);
 
 		validator.validate(personName, errors);