Bugfix/bug] in theme toggle button #98 #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
krishnaacharyaa
requested changes
Mar 29, 2024
There was a problem hiding this comment.
Thank you @Janith-Chamikara for the very quick PR, just a couple of concerns
- Please follow the 5th point of the contributing guidelines
- Address Issues section in the description, please properly update it and the below section by referring other merged PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to fix the flickering issue of the theam toggle button
Description
This issue has occured because the callback function inside the useEffect only runs after the dom mutations and browser paints the screen.So in order to fix that I used useLayoutEffect instead of useEffect as the provided callback inside the useLayoutEffect runs before the browser paints the screen.
Images
Wanderlust.-.Google.Chrome.2024-03-29.12-04-15.mp4
Issue(s)
#98
Prerequisites