-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core-#177: Added the eslint in the husky #337
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you @Ameerjafar! Your PR title meets our guidelines. |
@Ameerjafar pardon me, after research figured out that lets not use the airbnb, lets use the prettier:recommend and eslint:recommended. Kindly make sure that we use the best configuration out of https://fullstackopen.com/en/part3/validation_and_es_lint#lint |
Thank you @Ameerjafar! Your PR title meets our guidelines. |
@krishnaacharyaa can you kindly check now sir. |
Hey @krishnaacharyaa! Thank you for going through the contributing guidelines. Give Krishna sometime, I hope he'll show up 😜 |
Hey @krishnaacharyaa! Hold your horses 🐴! Thanks for your PR, but we have some style rules around here. Your PR title doesn't quite cut the mustard. Make sure you follow our contribution guidelines: PR titles should look like Check out our contributor guidelines for more details. Fix it up, and I'll be happy to take another look 😉. |
Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa |
Hey @krishnaacharyaa! Thanks for sticking to the guidelines! High five! 🙌🏻 |
Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa |
Hey @krishnaacharyaa! Thanks for sticking to the guidelines! High five! 🙌🏻 |
Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa |
Summary
i have added the eslint in the husky folder
Description
initially we have the commit regex and prettier in the husky now I added the airbnb eslint in the husky
Issue(s) Addressed
Enter the issue number of the bug(s) that this PR fixes
Prerequisites