feat-#36 fix-#97: Adding theme toggle functionality for the entire app (#95) #95
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @Raghunandan-29 , thank you for the PR, LGTM. Just couple of suggestions. |
|
Sure, I will change the CSS and also follow the Community guidelines |
|
Can you kindly push the changes @Raghunandan-29 which is posted in the discord |
There was a problem hiding this comment.
Thank you @Raghunandan-29 for this amazing much needed PR, end functionality wise looks cool, but we also aim for code quality, which is presently not satisfying, kindly address the comments, and please follow the comunity guidelines,
1, 2,3, 4, 5was not followed, is what I observed,
Looking forward for the upcoming commits :)
|
@Raghunandan-29 updates please |
…button code and also stylings in index.css are converted to tailwind css
|
Sorry krishna, I accidentally changed the path of skeleton.tsx, I will fix this |
There was a problem hiding this comment.
Hey @Raghunandan-29, thank you for the quick update and sincere considerations of the comments and working on it.
Sorry but still the community guidelines of PR title and commit regex is not followed, hopefully you'll pick that up in the next one, apart from that no complaints, the quality is improved 200% from the previous one and this is the very quality we are aiming for.
Thank you @Raghunandan-29
Just a small observation here when i saw the deployment, when you are in the dark mode and come back to home page from details or add page, you see the default is sun and then it switches to the dark, for a millisecond that happens, can you look into it?
It might be a little challenging, you might have to play with react hooks in a better way, but would be a great learning, can you pick this one part in this PR then we can close, or if you want to take it in the another PR, we'll take it, I am totally okay with that :)
|
Thanks Krishna! and for that bug I would like to work with new PR so, I will raise new issue for this and work on it. Hope it is okay with you. |
|
Please share the created link of the issue here, so that we can merge this PR |
|
Issue link #98 (comment) |
krishnaacharyaa
changed the title
Summary
This PR resolves issue #36 and issue #97
Description
This PR adds Theme-toggle-button and also scroll to top for posts which has the larger description
Images
Theme-toggle button is responsive :
this is for mobile screens
this is for tablet and desktop screens
Issue(s) Addressed
Closes #36
Closes #97
Prerequisites