standardize license header #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ckadner did you had time to test it? |
ckadner
reviewed
Feb 27, 2024
ckadner
reviewed
Feb 27, 2024
ckadner
reviewed
Feb 27, 2024
chore: Format all *.go files to have the empty line above the package declaration The goal is to add a new step to take care of the license headers as part of the `go fmt` make goal to keep it consistent across all files it is present. Signed-off-by: Spolti <[email protected]>
Signed-off-by: Spolti <[email protected]>
Signed-off-by: Spolti <[email protected]>
Signed-off-by: Spolti <[email protected]>
|
Thanks for the review @ckadner, I've applied your suggestions, please take a look. |
ckadner
requested changes
Mar 12, 2024
ckadner
reviewed
Mar 12, 2024
spolti
force-pushed
the
issue74
branch
2 times, most recently
from
c6c3dbd to
ce9ef7c
Compare
Signed-off-by: Spolti <[email protected]>
what do you mean by the cleanup? |
Signed-off-by: Spolti <[email protected]>
ckadner
approved these changes
Mar 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for all the effort you put on reviewing this @ckadner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Format all *.go files to have the empty line above the package declaration
The goal is to add a new step to take care of the license headers as part
of the
go fmtmake goal to keep it consistent across all files it is present.Motivation
Modifications
Result