Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): add minimal CI #15

Merged
merged 18 commits into from
Jan 29, 2024
Merged

feat(ci): add minimal CI #15

merged 18 commits into from
Jan 29, 2024

Conversation

OverOrion
Copy link
Collaborator

No description provided.

@OverOrion
feat(ci): add check-diff target
cb14312 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
feat(ci): add basic gh actions ci workflow
de1dc1c 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
fix(ci): make lint-fix results
c8108f9 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
fix(lint): trivial lint fixes
4b11b6d 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
fix(test): followup on unit tests
5c634b9 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
fix(license): unify/add missing license
e1ca6a5 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
feat(ci): add license-check target
5b642a5 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
fix(rbac): add required rbac permissions to run inside k8s
524384e 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
feat(ci): add artifacts.yaml
770674d 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
feat(ci): enable e2e-test in ci
6a69eec 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
fix(ci): add missing license-cache target
b404b34 
Signed-off-by: Szilard Parrag <[email protected]>
@OverOrion
Copy link
Collaborator Author

OverOrion commented Jan 26, 2024 •
edited
Loading

From codeql docs:

Code scanning is available for all public repositories on GitHub.com. Code scanning is also available for private repositories owned by organizations that use GitHub Enterprise Cloud and have a license for GitHub Advanced Security. For more information, see "About GitHub Advanced Security."

I do no think we have GH Enterprise Cloud or Advanced Security either, so I will remove the codeql step for now, and reintroduce it later.

kristofgyuracz
kristofgyuracz approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@kristofgyuracz kristofgyuracz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

pepov
pepov approved these changes Jan 26, 2024
View reviewed changes
.github/workflows/e2e.yaml Show resolved Hide resolved
@OverOrion OverOrion merged commit bc083af into main Jan 29, 2024
13 checks passed
@OverOrion OverOrion deleted the minimal-ci branch January 29, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofgyuracz kristofgyuracz kristofgyuracz approved these changes

@pepov pepov pepov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OverOrion @pepov @kristofgyuracz