Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mahdi khashan as a member #751

Merged

Conversation

mahdikhashan
Copy link
Member

@mahdikhashan mahdikhashan commented Feb 16, 2025

Hello,

I got to know Kubeflow out of blue, a few months ago, I enjoyed every moment using it for my university project and I did a very custom helm chart for myself:

  1. https://github.com/mahdikhashan/kubeflow-helm-chart
  2. my university course project (https://github.com/mahdikhashan/argocd-mlops-pipeline-kubeflow-mlflow)

then i joined community meetings and others like AutoML, Pipeline and Model-Registry.

some of my PRs and in progress Issues:

katib:

merged:

  1. [CI] ci job Test Build For Component katib-ui is flaky katib#2501
  2. [SDK] improve PVC error message katib#2491
  3. [DOCS] design image in HP Optimization Proposal is in wrong path katib#2471

open:

  1. [EXAMPLE] implement a jupyter notebook example of LLM HP tuning katib#2480

some other reported issue:

  1. [SDK] ValueError: <HUB_TOKEN> is not a valid HubStrategy, please select one of ['end', 'every_save', 'checkpoint', 'all_checkpoints'] katib#2495
  2. [TEST] when running e2e tests on local, when the katib is not available - it should exit without continuting to run tests katib#2513
  3. [SDK] objective_metric_name to be required katib#2481

pipeline:

  • merged:
  1. [frontend] Node version is not up to date in the docs pipelines#11566
  • open:
  1. [sdk] TypeError with list input/output when list type is included pipelines#11536
  2. chore(tests): Create a test to check whether requirements.txt was generated with pip-compile pipelines#11495

trainer:

  • open:
  1. Leverage GitHub action arm64 runner trainer#2422

mpi-operator:

  • open:
  1. increase intel-oneapi-mpi-devel version to 2021.14 mpi-operator#681

website:

open:

  1. katib: [USERGUIDE] LLM Hyperparameter Optimization API website#3952

merged:

  1. [pipelines] typo in userguides datahandling parameters page website#3974

manifest:

merged:

  1. fix cert-manager wrong path in standalone installation section manifests#2924
  2. fix warnings after kustomize build in contrib manifests#2992

open:

  1. fix warnings in model-registry manifests#2997

kserve:

merged:

  1. update kustomization kserve/models-web-app#99

I also helped with reviewing some:

  1. [GSoC] Add e2e test for tune api with LLM hyperparameter optimization katib#2420
  2. [GSOC] optuna suggestion service logic update katib#2446
  3. Support old-style TensorFlow events (tensorboard) katib#2467
  4. [SDK] Support PyTorchJob as a Trial Worker katib#2512

I kindly request for this chance to become a part of this active community since so far it has been a great learning opportunity for me and I do want to contribute and have more and more impact on it - and be a part of its very blessing future.

thanks for considering my application

@andreyvelich @Electronic-Waste @helenxie-bit

Copy link

Hi @mahdikhashan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahdikhashan Well deserved! Your accomplishments are amazing!

Btw, can you please sign your cla? https://cla.developers.google.com/clas

/lgtm
/assign @andreyvelich @tenzen-y @helenxie-bit

@mahdikhashan
Copy link
Member Author

@mahdikhashan Well deserved! Your accomplishments are amazing!

Btw, can you please sign your cla? https://cla.developers.google.com/clas

/lgtm /assign @andreyvelich @tenzen-y @helenxie-bit

thank you - I hope I can learn more from you @Electronic-Waste.

I checked the link and it was already signed. dono what is wrong 😑

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

Absolutely!
Thank you for your contribution!

@franciscojavierarceo
Copy link
Contributor

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Electronic-Waste, franciscojavierarceo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [franciscojavierarceo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5f86d82 into kubeflow:master Feb 16, 2025
2 of 3 checks passed
@helenxie-bit
Copy link
Contributor

Thank you for all the contributions and Welcome!

@andreyvelich
Copy link
Member

Thank you for all of your great contributions @mahdikhashan 🎉
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants