Skip to content

Commit

Permalink
Add new check to PR templates and tweak UI GA (#833)
Browse files Browse the repository at this point in the history
Signed-off-by: Lucas Fernandez <[email protected]>
  • Loading branch information
lucferbux authored Mar 3, 2025
1 parent f0aa6eb commit f325430
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 12 deletions.
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
- [ ] The developer has manually tested the changes and verified that the changes work.
- [ ] Code changes follow the [kubeflow contribution guidelines](https://www.kubeflow.org/docs/about/contributing/).
- [ ] **For first time contributors**: Please reach out to the [Reviewers](../OWNERS) to ensure all tests are being run, ensuring the label `ok-to-test` has been added to the PR.

If you have UI changes

Expand Down
18 changes: 13 additions & 5 deletions .github/workflows/ui-bff-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,20 @@ on:
push:
branches:
- "main"
paths:
- "clients/ui/**"
- "!LICENSE*"
- "!DOCKERFILE*"
- "!**.gitignore"
- "!**.md"

pull_request:
paths-ignore:
- "LICENSE*"
- "DOCKERFILE*"
- "**.gitignore"
- "**.md"
paths:
- "clients/ui/**"
- "!LICENSE*"
- "!DOCKERFILE*"
- "!**.gitignore"
- "!**.md"
jobs:
build:
runs-on: ubuntu-latest
Expand Down
19 changes: 13 additions & 6 deletions .github/workflows/ui-frontend-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,20 @@ on:
push:
branches:
- "main"
paths:
- "clients/ui/**"
- "!LICENSE*"
- "!DOCKERFILE*"
- "!**.gitignore"
- "!**.md"

pull_request:
paths-ignore:
- "LICENSE*"
- "DOCKERFILE*"
- "**.gitignore"
- "**.md"
paths:
- "clients/ui/**"
- "!LICENSE*"
- "!DOCKERFILE*"
- "!**.gitignore"
- "!**.md"
jobs:
test-and-build:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -47,4 +55,3 @@ jobs:
git diff
exit 1
fi
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,7 @@ readme.txt
mr-storage-initializer

# KServe manifests
istio-*
istio-*

# VSCode files
.vscode/

0 comments on commit f325430

Please sign in to comment.