Prepare kubeflow manifest for release

[lucferbux]

Description

Prepare kubeflow manifests for release adding a kubeflow manifest and allowing tagging in images

How Has This Been Tested?

Note: I still need to test the tag in my local environment
Test deployment just following the instructions

Merge criteria:

• All the commits have been signed-off (To pass the DCO check)

• The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work.
• Code changes follow the kubeflow contribution guidelines.

If you have UI changes

• The developer has added tests or explained why testing cannot be added.
• Included any necessary screenshots or gifs if it was a UI change.
• Verify that UI/UX changes conform the UX guidelines for Kubeflow.

[ederign]

Great work @lucferbux ! I've tested this locally and got it working after apply kubeflow/manifests#2989 !

[ederign]

Also, from /ui make kubeflow-deployment worked for me! @lucferbux as a FUP PR, we should add this option to UI readme.

[ederign]

/approve

[ederign]

/lgtm

[ederign]

@tarilabs @rareddy, As this touches manifests and actions, I don't have the right to merge it.

btw, the only part that I didn't test was the github action!

[tarilabs]

@ederign @lucferbux overall LGTM but I believe the instruction "stable" should PATCH the existing KF Dashboard ConfigMap; am I right? Otherwise, newer modification to the CM by the platform would be elided by this version in its entirety.

Please log this as a TODO task.

Then, I'm happy to merge this PR (and the TODO task github issue could be dealt with separately)

wdyt?

[lucferbux]

@ederign @lucferbux overall LGTM but I believe the instruction "stable" should PATCH the existing KF Dashboard ConfigMap; am I right? Otherwise, newer modification to the CM by the platform would be elided by this version in its entirety.

Please log this as a TODO task.

Then, I'm happy to merge this PR (and the TODO task github issue could be dealt with separately)

wdyt?

That's a great suggestion, and yeah, I just copied the overlay of kserve but then I realize they have in in centraldashboard which is weird, https://github.com/kubeflow/manifests/blob/master/apps/centraldashboard/upstream/overlays/kserve/patches/configmap.yaml

Let me rework that and test the tag release and it would be ready to go, thanks a log @tarilabs

[tarilabs]

Let me rework that and test the tag release and it would be ready to go, thanks a log @tarilabs

it's good with me if you want to work on this now, or later. Up to you when is most suitable. Just lmk again when time to merge this PR

[lucferbux]

Ok a couple of things:

1. I've removed the kubeflow overlay, got istio as the main one added the kubeflow namespace as an opinionated install and changed all the docs to point at that
2. I've removed the configmap with that, I've added instructions on how to add that in a one line command (i think it's the best and we can add that into the install docs too)
3. I've tested the tag release in my fork and it just works great (pointing at my registry)

[tarilabs]

thanks @lucferbux

/lgtm

@ederign ?

[ederign]

@tarilabs @lucferbux I did the installation again and can confirm that it works. (I didn't tested the gh action)

[ederign]

/approve

[tarilabs]

/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tarilabs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment