Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove description in mui-theme and revert back changes in default theme #795

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

lucferbux
Copy link
Contributor

Description

  • Removes description in MUI Theme to match the rest of the components
  • Default style gets back the old icons

MUI Theme
Screenshot 2025-02-12 at 11 51 08

Default
Screenshot 2025-02-12 at 11 47 03

How Has This Been Tested?

  1. Start the dev environment and check both MR and MR settings page
  2. Change the STYLE_THEME env variable to default and check the pages again

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great @lucferbux - tested both themes in the MR UI, and the description is hidden in the MUI theme.

These are outside the scope of the current PR, but while reviewing, I noticed a couple things:

  1. Page padding is missing in the default PF theme :
Screenshot 2025-02-13 at 3 34 29 PM
  1. The navbar could benefit from a darker version of the logo:
Screenshot 2025-02-13 at 3 37 05 PM
  1. There is extra spacing in between the masthead toggle and the namespace selector in the "Default" image above.

Approving as-is since these are not blockers - happy to submit standalone PRs to address these.

@lucferbux
Copy link
Contributor Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jenny-s51, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux
Copy link
Contributor Author

/lgtm

Copy link

@lucferbux: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexcreasy
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 14, 2025
@google-oss-prow google-oss-prow bot merged commit 118d0f6 into kubeflow:main Feb 14, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants