Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update frontend to support module federation #798

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

christianvogt
Copy link

@christianvogt christianvogt commented Feb 12, 2025

Description

Builds on top of #793

  • Updates the frontend to always call the api with a prefix: /model-registry/api/vi. Required a change to BFF to support this.
  • Added a stub module federation configuration but do not yet expose any APIs.
  • Updated the webpack configs to support module federation with publicPath: 'auto' then other path updates to ensure standalone and integrated use cases continue to work.
  • The change to index.tsx and bootstrap.tsx were necessary for module federation

How Has This Been Tested?

Follow the instructions under clients/ui/docs/kubeflow-development-guide.md
Tested frontend dev and build modes.

While module federation has been included and tested in a dev environment, exposing APIs has been omitted from this PR. There is currently no test or use case implemented yet for module federation support.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign griffin-sullivan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt christianvogt changed the title [WIP] update frontend to support module federation update frontend to support module federation Feb 13, 2025
1. Just run the repo in kubeflow dev mode

```shell
make dev-start-kubeflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make dev-start-kubeflow
cd clients/ui && make dev-start-kubeflow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the commands in all the clients/ui/docs are relative to the clients/ui dir


```shell
kubectl port-forward svc/profiles-kfam 8081:8081 -n kubeflow
```
Copy link
Member

@jenny-s51 jenny-s51 Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
After setting up port forwarding, you can access the UI by navigating to:
http://localhost:8080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants