-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update frontend to support module federation #798
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: lucferbux <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Christian Vogt <[email protected]>
0d77224
to
1e24707
Compare
1. Just run the repo in kubeflow dev mode | ||
|
||
```shell | ||
make dev-start-kubeflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make dev-start-kubeflow | |
cd clients/ui && make dev-start-kubeflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the commands in all the clients/ui/docs
are relative to the clients/ui
dir
|
||
```shell | ||
kubectl port-forward svc/profiles-kfam 8081:8081 -n kubeflow | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``` | |
After setting up port forwarding, you can access the UI by navigating to: | |
http://localhost:8080 |
Description
Builds on top of #793
/model-registry/api/vi
. Required a change to BFF to support this.publicPath: 'auto'
then other path updates to ensure standalone and integrated use cases continue to work.index.tsx
andbootstrap.tsx
were necessary for module federationHow Has This Been Tested?
Follow the instructions under clients/ui/docs/kubeflow-development-guide.md
Tested frontend dev and build modes.
While module federation has been included and tested in a dev environment, exposing APIs has been omitted from this PR. There is currently no test or use case implemented yet for module federation support.
Merge criteria:
DCO
check)If you have UI changes