Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing nested-asyncio from Model Registry client #802

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blublinsky
Copy link

Description

Replaced async-runner by a new implementation to avoid usage of nested-async to address #774

How Has This Been Tested?

Unit tests and running in our Ray environment

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • [ x] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [x ] The developer has manually tested the changes and verified that the changes work.
  • [x ] Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -0,0 +1,102 @@
# from https://gist.github.com/blink1073/969aeba85f32c285235750626f2eadd8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should verify if alternative libraries exists on pypi to avoid having to introduce multiple licensing in the project itseld

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarilabs, We had the same need in our internal project, and this was the only solution that I found after more than a week of searches and conversations with my colleagues. If you can find a better solution for this I will be very interested to hear it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but maybe there are ways we could allow user to plug their own executor/runner strategies, without requiring necessarily to opt for one or the other ourselves, maybe picking one

(this is because seems to me at the end of the day it's the same signature/contract)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean introducing a base class and using AsyncTaskRunner as a default? To make ModelRegistry independent of it we will also need a factory class, doing instantiation.

So add 2 additional classes. So yes, this can be done. Is it worth it?
If the answer is yes, we can do it

@blublinsky blublinsky force-pushed the remove-nested-asyncio branch from 775f13a to 6bd81c8 Compare February 14, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants