Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor webhook patching logic #2409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ImpSy
Copy link
Contributor

@ImpSy ImpSy commented Jan 28, 2025

Purpose of this PR

Refactoring the webhook patching logic to simplify patching functions
Fixes #2238

Proposed changes:

  • Move common fields from DriverSpec and ExecutorSpec into SparkPodSpec
  • Modify sparkPod defaulter to split validation and patching logic

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mwielgus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ImpSy ImpSy force-pushed the refactoring-webhook-patching-logic branch 2 times, most recently from 4fc9052 to 0473abd Compare January 28, 2025 15:27
@ImpSy ImpSy force-pushed the refactoring-webhook-patching-logic branch from 0473abd to 4e8942c Compare January 28, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring: webhook findContainer to avoid calling it in every patch function
1 participant