-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2170: Use SSA to reconcile TrainJob components #2431
Open
astefanutti
wants to merge
15
commits into
kubeflow:master
Choose a base branch
from
astefanutti:pr-ssa
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c02d72c
KEP-2170: Use SSA to reconcile TrainJob components
astefanutti 2a3763f
Enable Unstructured caching in controller manager config
astefanutti 59d02ce
Bump JobSet API to v0.8.0-devel
astefanutti aa4621e
Fix PodGroup apply configuration
astefanutti 207af07
API to apply config conversion util functions
astefanutti 0472eb3
Only add namespace to TrainingRuntime object key
astefanutti e8f9ffa
Fix EnvVar upsert
astefanutti 38ee5a2
Update unit tests
astefanutti 4913fb6
Fix JobSet resource requirements
astefanutti 6024450
Resolve build issues with launcher job
astefanutti c834963
Use apply config for MPI ConfigMap and Secret
astefanutti c981d00
ComponentBuilderPlugin now returns an array
astefanutti 7511f90
Use plain apply configurations instead of unstructured
astefanutti 56dc0dd
Use apply config in EnforceMLPolicy plugins
astefanutti ade55bd
Do not update JobSets that are not suspended
astefanutti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use these toolchains? Who is bringing this? JobSet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the
replaceadded to override the transitive dependencies coming from the newer JobSet version,go mod tidykeeps adding this. I'd need to dig into it more to understand why.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm, interesting. Actually, Go < 1.23.4, they enforce to specify toolchain. But after the Go 1.23.4, the restrictions are relaxed. So, IIUC, this technically could be removed.
Or, we may just bump to Kube 1.32 as library. @andreyvelich Do you want to avoid bumping kube lib to 1.32 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we should try to avoid toolchain here if that is possible.
Let's bump k8s to 1.32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astefanutti Should we bump k8s libs to 1.32 in this PR to remove toolchain ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreyvelich yes, do you prefer the upgrade to be done in this PR or separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's maybe first create PR to migrate to 1.32 if that is easier for you.