Skip to content

Commit

Permalink
Create third-party dir for JobSet
Browse files Browse the repository at this point in the history
Signed-off-by: Andrey Velichkevich <[email protected]>
  • Loading branch information
andreyvelich committed Jan 15, 2025
1 parent 96ec640 commit 1dd0225
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 17 deletions.
20 changes: 3 additions & 17 deletions manifests/v2/overlays/manager/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,16 @@ resources:
- ../../base/manager
- ../../base/rbac
- ../../base/webhook
- https://github.com/kubernetes-sigs/jobset/releases/download/v0.7.2/manifests.yaml
- ../../third-party/jobset # Comment this line if the JobSet is installed on Kubernetes cluster.

# Update the Kubeflow Training manager image tag.
images:
- name: kubeflow/training-operator-v2
newTag: latest

# Disable postfix for Secret and ConfigMap
generatorOptions:
disableNameSuffixHash: true

# Secret for the Kubeflow Training webhook.
secretGenerator:
- name: training-operator-v2-webhook-cert
namespace: kubeflow-system

# Config for the JobSet manager.
# TODO (andreyvelich): Remove this when this is released: https://github.com/kubernetes-sigs/jobset/issues/720
configMapGenerator:
- files:
- jobset_manager_config.yaml
name: jobset-manager-config

# Add required patches.
patchesStrategicMerge:
- patches/jobset_remove_namespace.yaml # Remove namespace from the JobSet release manifests.
- patches/jobset_config_patch.yaml # Add custom manager config to the JobSet.
options:
disableNameSuffixHash: true
19 changes: 19 additions & 0 deletions manifests/v2/third-party/jobset/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- https://github.com/kubernetes-sigs/jobset/releases/download/v0.7.2/manifests.yaml

# Config for the JobSet manager.
# TODO (andreyvelich): Remove this when this is released: https://github.com/kubernetes-sigs/jobset/issues/720
configMapGenerator:
- name: jobset-manager-config
files:
- jobset_manager_config.yaml
options:
disableNameSuffixHash: true

# Add required patches.
patchesStrategicMerge:
- patches/jobset_remove_namespace.yaml # Remove namespace from the JobSet release manifests.
- patches/jobset_config_patch.yaml # Add custom manager config to the JobSet.

0 comments on commit 1dd0225

Please sign in to comment.