Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Concepts" / "Multi-Tenancy" section #3977

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Jan 27, 2025

closes #3707

As discussed, having the "Concepts" sidebar section with only "Multi-Tenancy" is not helpful to users, especially when the "Multi-Tenancy" pages are out of date and not correct.

This PR removes the Concepts / Multi-Tenancy pages and redirects them to Components / Central Dashboard / Profiles and Namespaces, as this is the most up-to-date information about how multi-tenancy works.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign james-jwu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Mathew Wicks <[email protected]>
@thesuperzapper thesuperzapper changed the title Remove "Components" / "Multi-Tenancy" section Remove "Concepts" / "Multi-Tenancy" section Jan 27, 2025
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change.
/lgtm
/assign @kubeflow/wg-manifests-leads @kubeflow/wg-notebooks-leads

@thesuperzapper I even think that we should move Kubeflow projects outside of components section to give them more visibility.
So the left panel can be:

About
Getting Started
Kubeflow Notebooks
Kubeflow Model Registry
Kubeflow Spark Operator
Kubeflow Trainer
Kubeflow Katib
Kubeflow KServe
Kubeflow Pipelines
Kubeflow Dashboard
Distributions
Releases

We can order components by ML lifecycle (similar to this diagram: https://www.kubeflow.org/docs/started/architecture/#introducing-the-ml-lifecycle) or alphabetically. Personally, I prefer ML Lifecycle order.

Any thoughts @kubeflow/wg-pipeline-leads @kubeflow/wg-data-leads @kubeflow/kubeflow-steering-committee @StefanoFioravanzo @juliusvonkohout @franciscojavierarceo @kubeflow/wg-training-leads @kubeflow/wg-notebooks-leads ?

@franciscojavierarceo
Copy link
Contributor

Yeah I agree with that

@thesuperzapper
Copy link
Member Author

@andreyvelich let's discuss any other changes in a separate issue.

But to respond here, while I agree that we should reorder the components sidebar to ML lifecycle order, I strongly disagree with moving the components to the top level.

It will just clutter the website and make it harder to browse, especially as we add more components.

There are also technical reasons why it would be ill-advised, mainly around the fact that the HTTP paths come from the folders, and historical redirects.

@juliusvonkohout
Copy link
Member

Yeah the multi-tenancy is more for platform administrators. Right now some components do not support hard multi-tenancy such as minio and ml-metadata for KFP. Maybe this is something we should keep somewhere or i just add it in the kubeflow/manifests readme for advanced users.

@thesuperzapper
Copy link
Member Author

@juliusvonkohout the reason we are proposing to remove it (and why others seem to be agreeing) is that the information is really out of date, and not correct (especially after the changes to how we use Istio in 1.9.1).

As stated, I propose we remove the sidebar section and redirect it to the "profiles" guide, as this the most practical info for end users relating to multi-user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

So there's no concepts? Your concepts page is empty.
4 participants