Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup stale objects #3538

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jan 20, 2025

What this PR does / why we need it:
This PR introduces mini cleanup framework to delete stale objects (from removed addons for example). It will work even for the types not available at compile time.

Which issue(s) this PR fixes:

Fixes #3196

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Cleanup the stale objects from the `unattended-upgrades` addon removed in KubeOne 1.8

Documentation:

NONE

@kron4eg kron4eg requested a review from xmudrii January 20, 2025 19:01
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2025
Signed-off-by: Artiom Diomin <[email protected]>
pkg/tasks/cleanup.go Outdated Show resolved Hide resolved
pkg/tasks/tasks.go Outdated Show resolved Hide resolved
pkg/tasks/tasks.go Outdated Show resolved Hide resolved
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg kron4eg requested a review from xmudrii February 3, 2025 11:38
@kron4eg
Copy link
Member Author

kron4eg commented Feb 3, 2025

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Feb 3, 2025

@xmudrii PTAL again

@xmudrii
Copy link
Member

xmudrii commented Feb 5, 2025

/release-note-edit

Cleanup the stale objects from the `unattended-upgrades` addon removed in KubeOne 1.8

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5de3d99a67fc921ae75dd8632dab5eecc52242e6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@kubermatic-bot kubermatic-bot merged commit 2d66472 into kubermatic:main Feb 5, 2025
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.10 milestone Feb 5, 2025
@kron4eg kron4eg deleted the stale-objects branch February 5, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeOne 1.8.0 removes the kured DaemonSet, keep other kured resources
3 participants