-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
full clone cacert from config object #1437
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1437 +/- ##
=========================================
Coverage ? 70.47%
=========================================
Files ? 89
Lines ? 2652
Branches ? 553
=========================================
Hits ? 1869
Misses ? 781
Partials ? 2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brendandburns @tg123 As far as I see there is still an issue with this implementation. The certificates are now copied from the KubernetesClientConfiguration
instance to each consuming KubernetesClient
instance. Each KubernetesClient
instance will dispose their copied X509Certificate2
instances on their Dispose()
call, but the config.SslCaCerts
will get never disposed as KubernetesClientConfiguration
does not implement IDisposable
.
fix #1436