Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full clone cacert from config object #1437

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Oct 25, 2023

fix #1436

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2023
@tg123 tg123 marked this pull request as draft October 25, 2023 20:40
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2023
@tg123 tg123 marked this pull request as ready for review October 25, 2023 21:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@f55d1fa). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##             master    #1437   +/-   ##
=========================================
  Coverage          ?   70.47%           
=========================================
  Files             ?       89           
  Lines             ?     2652           
  Branches          ?      553           
=========================================
  Hits              ?     1869           
  Misses            ?      781           
  Partials          ?        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tg123 tg123 changed the title full clone cacert from config ojb full clone cacert from config object Oct 26, 2023
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f3415d into kubernetes-client:master Oct 26, 2023
12 checks passed
Copy link
Contributor

@PSanetra PSanetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brendandburns @tg123 As far as I see there is still an issue with this implementation. The certificates are now copied from the KubernetesClientConfiguration instance to each consuming KubernetesClient instance. Each KubernetesClient instance will dispose their copied X509Certificate2 instances on their Dispose() call, but the config.SslCaCerts will get never disposed as KubernetesClientConfiguration does not implement IDisposable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubernetesClientConfiguration is not thread-safe
5 participants