Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OnError event to MetaObjectLock #1585

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Added OnError event to MetaObjectLock #1585

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4835a2c
Added OnError event to MetaObjectLock
fh-tmccurdy Sep 13, 2024
e396bd9
Updated event name
fh-tmccurdy Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/KubernetesClient/LeaderElection/ResourceLock/MetaObjectLock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ public abstract class MetaObjectLock<T> : ILock
private readonly string identity;
private T metaObjCache;

/// <summary>
/// OnError is called when there is a http operation error.
/// </summary>
public event Action<HttpOperationException> OnError;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about OnHttpError？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did consider it, so happy to use it if everyone agrees. I was just trying to match LeaderElectors event name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about Action<Exception> OnError
to align with all other OnError in this libarary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it to OnHttpError for now.


protected MetaObjectLock(IKubernetes client, string @namespace, string name, string identity)
{
this.client = client ?? throw new ArgumentNullException(nameof(client));
Expand Down Expand Up @@ -47,8 +52,9 @@ public async Task<bool> CreateAsync(LeaderElectionRecord record, CancellationTok
Interlocked.Exchange(ref metaObjCache, createdObj);
return true;
}
catch (HttpOperationException)
catch (HttpOperationException e)
{
OnError?.Invoke(e);
// ignore
}

Expand Down Expand Up @@ -79,8 +85,9 @@ public async Task<bool> UpdateAsync(LeaderElectionRecord record, CancellationTok
Interlocked.Exchange(ref metaObjCache, replacedObj);
return true;
}
catch (HttpOperationException)
catch (HttpOperationException e)
{
OnError?.Invoke(e);
// ignore
}

Expand Down
Loading