Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prow build check is broken #538

Closed
jkh52 opened this issue Nov 3, 2023 · 2 comments
Closed

Prow build check is broken #538

jkh52 opened this issue Nov 3, 2023 · 2 comments

Comments

@jkh52
Copy link
Contributor

jkh52 commented Nov 3, 2023 •
edited
Loading

Multiple PRs are stuck because prow checks are failing with:

Docker in Docker enabled, initializing...
================================================================================
Starting Docker: docker.
Waiting for docker to be ready, sleeping for 1 seconds.
================================================================================
Done setting up docker in docker.
+ WRAPPED_COMMAND_PID=173
+ wait 173
+ make docker-build/proxy-agent-arm64
make ARCH=arm64 docker-build/proxy-agent
make[1]: Entering directory '/home/prow/go/src/sigs.k8s.io/apiserver-network-proxy'
docker buildx inspect img-builder > /dev/null || docker buildx create --name img-builder --use
ERROR: no builder "img-builder" found
img-builder
(unset)
echo "Building proxy-agent for arm64"
Building proxy-agent for arm64
docker buildx build . --pull --output=type=docker --platform linux/arm64 --build-arg ARCH=arm64 -f artifacts/images/agent-build.Dockerfile -t gcr.io//proxy-agent-arm64:4865c8a1a55dc1ad383[2](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_apiserver-network-proxy/536/pull-apiserver-network-proxy-docker-build-arm64/1716930229299056640#1:build-log.txt%3A2)053de7d5f2d9ad2b597e
#1 [internal] booting buildkit
#1 pulling image moby/buildkit:buildx-stable-1
#1 pulling image moby/buildkit:buildx-stable-1 8.1s done
#1 creating container buildx_buildkit_img-builder0
#1 creating container buildx_buildkit_img-builder0 1.2s done
#1 DONE 9.3s
ERROR: invalid tag "gcr.io//proxy-agent-arm64:4865c8a1a55dc1ad3832053de7d5f2d9ad2b597e": invalid reference format
make[1]: *** [Makefile:196: docker-build/proxy-agent] Error 1
make[1]: Leaving directory '/home/prow/go/src/sigs.k8s.io/apiserver-network-proxy'
make: *** [Makefile:255: docker-build/proxy-agent-arm64] Error 2
+ EXIT_VALUE=2
+ set +o xtrace
Cleaning up after docker in docker.
================================================================================
Cleaning up after docker

It may be fallout from recent change: #529

It may be tempting to update prow to pass an explicit REGISTRY=, but it might be nicer to simplify make docker-build-* targets to use local-only image tags.

Also, we should remove the gcloud command in our Makefile (cloud-provider extraction).
@jkh52
Copy link
Contributor Author

jkh52 commented Nov 3, 2023

/assign @cheftako

This was referenced Nov 4, 2023
Merged
Merged
@cheftako cheftako mentioned this issue Nov 6, 2023
Merged
k8s-ci-robot pushed a commit to kubernetes/test-infra that referenced this issue Nov 6, 2023
@cheftako
Fix presubmit for K8s-sigs/ANP.
dc8d23e 
Fixing kubernetes-sigs/apiserver-network-proxy/issues/538
Issue is REGISTRY is not set.
We used to pull the registry using gcloud.
This breaks when not running on GCP.
Registry is not actually needed for the presubmit.
However we still need a non-empty string.
Setting a placeholder value for the test.
@cheftako
Copy link
Contributor

cheftako commented Nov 6, 2023

I believe fixed with kubernetes/test-infra#31196

@cheftako cheftako closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cheftako @jkh52