-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Dependabot for automatic Docker and Gomod updates #535
Conversation
Welcome @zhuxiaow0! |
Hi @zhuxiaow0. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
.github/dependabot.yml
Outdated
gomod-dependencies: | ||
patterns: | ||
- '*' | ||
- package-ecosystem: gomod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This go.mod has constraints that a robot may not be able to understand (not to get ahead of k/k go.mod).
Let's remove the /konnectivity-client entry altogether and stick with top level only for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Generally this seems good but I have no experience with dependabot, is there anyone familiar that can LGTM? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkh52, zhuxiaow0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/retest-required |
/assign @cheftako |
i've used dependabot a bunch, my only concern here is that it will start automatically proposing updates to the go.mod, so long as we are ok with accepting the reviews around that work then i think this is a good idea. |
/lgtm |
/retest-required |
/retest |
Opened #538 for test error |
/retest |
@zhuxiaow0, this change hasn't generated any PRs that I can see. Do you see anything missing? |
Hi @jkh52 , could you check in insights/dependency graph section to see if dependabot has been enabled? |
At https://github.com/kubernetes-sigs/apiserver-network-proxy/network/updates, I see "Dependabot version updates aren't configured yet". But if I click "Configure", it generates exactly the same file + contents as this PR... |
Enable Dependabot for Dockerfile and go.mod updates.
This will update images in Dockerfile
FROM
statements, and go modules.The purpose is to drastically reduce number of vulnerabilities that affect this repo,
by keeping dependencies up-to-date.
This PR is created by a script. Please let me know if we should modify any values.