-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New parameter additionalTags to tag EBS volumes #185
New parameter additionalTags to tag EBS volumes #185
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dkoshkin If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @dkoshkin. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 487
💛 - Coveralls |
/ok-to-test |
23628b3
to
b54cf6d
Compare
/retest |
b54cf6d
to
68948ee
Compare
/close |
@leakingtapan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bug 1955474: Rebase v1.0.0
Is this a bug fix or adding new feature?
New Feature
Fixes #180
What is this PR about? / Why do we need it?
This PR enables tagging created EBS volumes with custom tags. Most of the plumbing was already there since a tag is used to identify the volume, exposed a new parameter
additionalTags
and added unit test cases.What testing is done?