Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameter additionalTags to tag EBS volumes #185

Closed

Conversation

dkoshkin
Copy link
Contributor

Is this a bug fix or adding new feature?
New Feature
Fixes #180

What is this PR about? / Why do we need it?
This PR enables tagging created EBS volumes with custom tags. Most of the plumbing was already there since a tag is used to identify the volume, exposed a new parameter additionalTags and added unit test cases.

What testing is done?

  • Unit test cases
  • Locally tested on a cluster

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkoshkin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bertinatto

If they are not already assigned, you can assign the PR to them by writing /assign @bertinatto in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @dkoshkin. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Jan 22, 2019

Pull Request Test Coverage Report for Build 487

  • 20 of 25 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 68.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloud/fakes.go 0 5 0.0%
Totals Coverage Status
Change from base Build 484: 0.2%
Covered Lines: 997
Relevant Lines: 1466

💛 - Coveralls

@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2019
@dkoshkin dkoshkin force-pushed the dkoshkin/additional-tags branch 2 times, most recently from 23628b3 to b54cf6d Compare January 25, 2019 23:24
@leakingtapan
Copy link
Contributor

/retest

@dkoshkin dkoshkin force-pushed the dkoshkin/additional-tags branch from b54cf6d to 68948ee Compare February 28, 2019 18:52
@leakingtapan
Copy link
Contributor

/close
For further discussion

@k8s-ci-robot
Copy link
Contributor

@leakingtapan: Closed this PR.

In response to this:

/close
For further discussion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery pushed a commit to Elbehery/aws-ebs-csi-driver that referenced this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to provide arbitrary EBS volume tags
4 participants