Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.6] 🐛: Tags defined in subnet spec should be applied #5321

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[release-2.6] 🐛: Tags defined in subnet spec should be applied #5321

merged 1 commit into from
Jan 28, 2025

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #5175

/assign damdo

Tags defined in subnet spec should be applied

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 24, 2025
Merged
5 tasks
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
@damdo
Copy link
Member

damdo commented Jan 27, 2025

Hey @fiunchinho it looks like this automated backport of your #5175 PR is failing linting,
would you be able to have a look? Thanks!

@damdo
Copy link
Member

damdo commented Jan 27, 2025

/assign @fiunchinho

@AndiDog AndiDog force-pushed the cherry-pick-5175-to-release-2.6 branch from e989aed to f66b66f Compare January 28, 2025 15:57
@AndiDog
Copy link
Contributor

AndiDog commented Jan 28, 2025

slices.Concat is only available in later Go versions from what we had in 2.6.x. I fixed that.

/approve

@fiunchinho please LGTM if you think the diff is fine.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndiDog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
fiunchinho
fiunchinho approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit e2dffa3 into kubernetes-sigs:release-2.6 Jan 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiunchinho fiunchinho fiunchinho approved these changes

@AndiDog AndiDog Awaiting requested review from AndiDog

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

Assignees

@fiunchinho fiunchinho

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @damdo @AndiDog @k8s-ci-robot @fiunchinho