Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Improve Machine remediation logs #11692

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Jan 16, 2025

What this PR does / why we need it:
This PR improve logs added when a machine is remediated by adding key value pair for Machine ns/name and another for the node name, while dropping the key "target" which contained a confusing "MHC.Namespace/MHC.Name/Machine.Name/Node.Name".

Also, message now uses a more intuitive "Machine has failed health check..." instead of "Target has failed health check"

/area machinehalthcheck

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/machinehalthcheck cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
This PR improve logs added when a machine is remediated by adding key value pair for Machine ns/name and for the node, while dropping the key "target" which contained a confusing "MHC.Namespace/MHC.Name/Machine.Name/Node.Name".

Also, message now uses a more intuitive "Machine has failed health check..." instead of "Target has failed health check"

/area machinehalthcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from fabriziopandini. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2025
@fabriziopandini fabriziopandini force-pushed the improve-machine-remediation-logs branch from 516eedc to 2a3b552 Compare January 16, 2025 12:42
@fabriziopandini fabriziopandini added the area/machinehealthcheck Issues or PRs related to machinehealthchecks label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2025
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 17, 2025
@sbueringer
Copy link
Member

Thx!

/lgtm

/assign @chrischdi

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 23f3bf9897456a7455a60ef1260957d1a8c48ff8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/machinehealthcheck Issues or PRs related to machinehealthchecks cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants