-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Improve Machine remediation logs #11692
base: main
Are you sure you want to change the base?
🌱 Improve Machine remediation logs #11692
Conversation
@fabriziopandini: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
516eedc
to
2a3b552
Compare
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
Show resolved
Hide resolved
Thx! /lgtm /assign @chrischdi |
LGTM label has been added. Git tree hash: 23f3bf9897456a7455a60ef1260957d1a8c48ff8
|
What this PR does / why we need it:
This PR improve logs added when a machine is remediated by adding key value pair for Machine ns/name and another for the node name, while dropping the key "target" which contained a confusing "MHC.Namespace/MHC.Name/Machine.Name/Node.Name".
Also, message now uses a more intuitive "Machine has failed health check..." instead of "Target has failed health check"
/area machinehalthcheck