Multi-target support v2 #211

gchaviaras-NS1 · 2024-05-31T13:52:45Z

In several use cases, due to the fact that Cluster Proportional Autoscaler (=CPA) is able to control only one deployment/replicasets, we end up having multiple deployments of CPA to control multiple deployments under the same Namespace. This situation is a bit redundant and creates an inefficient resource management by wasting resources both CPU and MEM.

This PR introduces multi target support functionality that allows a single instance of CPA to control multiple deployments/replicasets under the same Namespace

Is based and rebased from #159

Added:

Extra Config tests
target param renamed to targets
Docs
Updated helm charts

linux-foundation-easycla · 2024-05-31T13:52:49Z

The committers listed above are authorized under a signed CLA.

✅ login: palasanu / name: Palasanu George (7cb626c)

k8s-ci-robot · 2024-05-31T13:52:53Z

Welcome @gchaviaras-NS1!

It looks like this is your first PR to kubernetes-sigs/cluster-proportional-autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-proportional-autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

gchaviaras-NS1 · 2024-06-01T09:56:37Z

/assign @thockin

gchaviaras-NS1 · 2024-06-18T17:18:15Z

/assign @MrHohn

Any chance you could have a look?

thockin

It's been a VERY long time since I looked at this code in depth, sorry if it is slow.

Between this and https://github.com/kubernetes-sigs/cluster-proportional-autoscaler/pull/159we have 2 PRs on the same topic - which one do we keep and which do we close? Can we work together on one?

Since I am looking at this one, can you please:

squash
include something in the commit and PR messages aboout WHY this matters
include something in the README about the behavior

thockin · 2024-07-13T18:22:10Z

cmd/cluster-proportional-autoscaler/options/options.go

@@ -117,7 +123,7 @@ func (c *configMapData) Type() string {

 // AddFlags adds flags for a specific AutoScaler to the specified FlagSet
 func (c *AutoScalerConfig) AddFlags(fs *pflag.FlagSet) {
-	fs.StringVar(&c.Target, "target", c.Target, "Target to scale. In format: deployment/*, replicationcontroller/* or replicaset/* (not case sensitive).")
+	fs.StringVar(&c.Targets, "targets", c.Targets, "Targets to scale. In format: 'deployment/*,replicationcontroller/*,replicaset/*' (not case sensitive, comma delimiter supported).")


You can't break compat without a major change (e.g. 2.0.0). I suggest you still accept the old flag and add the new flag. If only the old flag is specified, you can convert it into the new-style list. If only the new flag is specified, no problem. If both are specified, it can be a fatal error.

@thockin Thanks for the comment.
In that case isn't it better to discard the targets flag and just stick with a single flag target that will support both single and multiple targets ?
I know it breaks the meaning of the singular form of the flag target because it will support multiple targets too, but it can be stated in the documentation.

I agree with just keeping the target flag, that was my initial idea.

@thockin I kept the Target flag; Supports both single and multiple targets.
Also I added an extra paragraph explaining the multi-target support feature.
Let me know if more changes are needed

Repurposing the original flag while keeping it backward compatible seems fine to me.

Co-authored-by: George Palasanu <[email protected]>

k8s-ci-robot · 2024-09-24T19:12:25Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gchaviaras-NS1
Once this PR has been reviewed and has the lgtm label, please ask for approval from mrhohn. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MrHohn

Added some minor comments. Sorry for my super long silence and thanks for adding this - seems to me an obvious use case.

Going forward I'm actually interested to see whether there is a potential to scale the solution beyond a namespace and beyond a single scale param config - not going to block this further though.

MrHohn · 2024-11-08T19:31:09Z

charts/cluster-proportional-autoscaler/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v2
 name: cluster-proportional-autoscaler
-version: 1.1.0
+version: 1.1.1


Less certain about helm chart version here - I would expect a minor version bump for CPA itself as this is introducing a new feature.

Should we probably bump this later once we have a new CPA version released?

MrHohn · 2024-11-08T19:41:06Z

pkg/autoscaler/k8sclient/k8sclient.go

+func (k *k8sClient) UpdateReplicas(expReplicas int32) (err error) {
+	for _, target := range k.scaleTargets.targets {
+		_, err := k.UpdateTargetReplicas(expReplicas, target)
+		if err == nil {


Should check for non-nil instead?
if err != nil { ...

MrHohn · 2024-11-08T19:47:52Z

pkg/autoscaler/k8sclient/k8sclient.go

@@ -270,10 +298,10 @@ func (k *k8sClient) updateReplicasAppsV1(expReplicas int32) (prevReplicas int32,

 	prevReplicas = scale.Spec.Replicas
 	if expReplicas != prevReplicas {
-		glog.V(0).Infof("Cluster status: SchedulableNodes[%v], TotalNodes[%v], SchedulableCores[%v], TotalCores[%v]", k.clusterStatus.SchedulableNodes, k.clusterStatus.TotalNodes, k.clusterStatus.SchedulableCores, k.clusterStatus.TotalCores)
+		glog.V(0).Infof("Cluster status: SchedulableNodes[%v], SchedulableCores[%v]", k.clusterStatus.SchedulableNodes, k.clusterStatus.SchedulableCores)
 		glog.V(0).Infof("Replicas are not as expected : updating replicas from %d to %d", prevReplicas, expReplicas)


Since we have multiple targets now, could we also log what is being scaled here?

k8s-ci-robot · 2024-11-16T02:29:48Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 31, 2024

k8s-ci-robot requested review from bowei and MrHohn May 31, 2024 13:52

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 31, 2024

k8s-ci-robot assigned thockin Jun 1, 2024

k8s-ci-robot assigned MrHohn Jun 18, 2024

thockin mentioned this pull request Jul 13, 2024

Multi-target support #159

Open

thockin reviewed Jul 13, 2024

View reviewed changes

Added: Multi-target support

7cb626c

Co-authored-by: George Palasanu <[email protected]>

gchaviaras-NS1 force-pushed the multi-target-support-rebased branch from f42d402 to 7cb626c Compare September 24, 2024 19:12

gchaviaras-NS1 requested review from thockin and palasanu September 24, 2024 19:15

MrHohn reviewed Nov 8, 2024

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi-target support v2 #211

Multi-target support v2 #211

gchaviaras-NS1 commented May 31, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 31, 2024 •

edited

Loading

k8s-ci-robot commented May 31, 2024

gchaviaras-NS1 commented Jun 1, 2024

gchaviaras-NS1 commented Jun 18, 2024

thockin left a comment

thockin Jul 13, 2024

gchaviaras-NS1 Aug 12, 2024

palasanu Sep 11, 2024

gchaviaras-NS1 Sep 24, 2024

MrHohn Nov 8, 2024

k8s-ci-robot commented Sep 24, 2024

MrHohn left a comment

MrHohn Nov 8, 2024

MrHohn Nov 8, 2024

MrHohn Nov 8, 2024

k8s-ci-robot commented Nov 16, 2024

Multi-target support v2 #211

Are you sure you want to change the base?

Multi-target support v2 #211

Conversation

gchaviaras-NS1 commented May 31, 2024 • edited Loading

linux-foundation-easycla bot commented May 31, 2024 • edited Loading

k8s-ci-robot commented May 31, 2024

gchaviaras-NS1 commented Jun 1, 2024

gchaviaras-NS1 commented Jun 18, 2024

thockin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 24, 2024

MrHohn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 16, 2024

gchaviaras-NS1 commented May 31, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 31, 2024 •

edited

Loading