Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.8.0 #801

Closed
19 of 20 tasks
kannon92 opened this issue Feb 26, 2025 · 14 comments
Closed
19 of 20 tasks

Release v0.8.0 #801

kannon92 opened this issue Feb 26, 2025 · 14 comments

Comments

@kannon92
Copy link
Contributor

kannon92 commented Feb 26, 2025

Release Checklist

  • All OWNERS must LGTM the release proposal
  • Verify that the changelog in this issue is up-to-date
  • For major or minor releases (v$MAJ.$MIN.0), create a new release branch.
    • an OWNER creates a vanilla release branch with
      git branch release-$MAJ.$MIN main
    • An OWNER pushes the new release branch with
      git push release-$MAJ.$MIN
  • Update things like README, deployment templates, docs, configuration, test/e2e flags.
    Submit a PR against the release branch:
    PR: update docs for release 0.8 #802
  • An OWNER prepares a draft release
    • Write the change log into the draft release.
    • Run
      make artifacts IMAGE_REGISTRY=registry.k8s.io/jobset GIT_TAG=$VERSION
      to generate the artifacts and upload the files in the artifacts folder
      to the draft release.
  • An OWNER creates a signed tag running
    git tag -s $VERSION
    and inserts the changelog into the tag description.
    To perform this step, you need a PGP key registered on github.
  • An OWNER pushes the tag with
    git push $VERSION
    • Triggers prow to build and publish a staging container image
      gcr.io/k8s-staging-jobset/jobset:$VERSION
  • Submit a PR against k8s.io,
    updating k8s.gcr.io/images/k8s-staging-jobset/images.yaml to
    promote the container images
    to production:
    release jobset 0.8.0 for images and charts kubernetes/k8s.io#7834
  • Wait for the PR to be merged and verify that the image registry.k8s.io/jobset/jobset:$VERSION is available.
  • Publish the draft release prepared at the Github releases page.
  • Add a link to the tagged release in this issue:
  • Send an announcement email to [email protected], [email protected] and [email protected] with the subject [ANNOUNCE] JobSet $VERSION is released
  • Add a link to the release announcement in this issue:
  • For a major or minor release, update README.md and docs/setup/install.md
    in main branch:
  • For a major or minor release, create an unannotated devel tag in the
    main branch, on the first commit that gets merged after the release
    branch has been created (presumably the README update commit above), and, push the tag:
    DEVEL=v0.$(($MAJ+1)).0-devel; git tag $DEVEL main && git push $DEVEL
    This ensures that the devel builds on the main branch will have a meaningful version number.
  • Close this issue

Highlights

Deprecations

Changelog

New Contributors

Full Changelog: v0.7.0...v0.8.0

@kannon92
Copy link
Contributor Author

Just a heads up. We published the images but I am not seeing them in registry.k8s.io so I am tracking down that issue.

The images are available in our staging repo and tag correctly.

@tenzen-y
Copy link
Member

Just a heads up. We published the images but I am not seeing them in registry.k8s.io so I am tracking down that issue.

The images are available in our staging repo and tag correctly.

In my side, it works well:

$ helm template jobset oci://registry.k8s.io/charts/jobset --version v0.8.0 | grep image:
Pulled: registry.k8s.io/charts/jobset:v0.8.0
Digest: sha256:e1f25f53ba4312f99bb60b92668d98104c549067d86756d30cbf1cf18f2b47f7
        image: "registry.k8s.io/jobset/jobset:v0.8.0"

@kannon92
Copy link
Contributor Author

can you pull the image?

@tenzen-y
Copy link
Member

can you pull the image?

Ah, you mean registry.k8s.io/jobset/jobse instead of registry.k8s.io/charts/jobset. If yes, I could not pull image as well.

@kannon92
Copy link
Contributor Author

Okay. It turns out we did not fully change all the promoter manifests.

We are good to go now!

podman pull registry.k8s.io/jobset/jobset:v0.8.0
Trying to pull registry.k8s.io/jobset/jobset:v0.8.0...
Getting image source signatures
Copying blob 3214acf345c0 skipped: already exists  
Copying blob 688513194d7a skipped: already exists  
Copying blob efa9d1d5d3a2 skipped: already exists  
Copying blob a62778643d56 skipped: already exists  
Copying blob 7c12895b777b skipped: already exists  
Copying blob 4aa0ea1413d3 skipped: already exists  
Copying blob 9aee425378d2 skipped: already exists  
Copying blob 0bab15eea81d skipped: already exists  
Copying blob 5664b15f108b skipped: already exists  
Copying blob da7816fa955e skipped: already exists  
Copying blob 7d2ef468776a skipped: already exists  
Copying blob bfb59b82a9b6 skipped: already exists  
Copying config ce72a12761 done   | 
Writing manifest to image destination
ce72a12761d98d52b2702991e371156d02b06ac4c77b7293e4f6749825466a87

@kannon92
Copy link
Contributor Author

@tenzen-y
Copy link
Member

Congrats 🎉

@kannon92
Copy link
Contributor Author

https://groups.google.com/u/1/a/kubernetes.io/g/wg-batch/c/REDpyzQg4EE

I have a PR up to update latest docs now also.

@kannon92
Copy link
Contributor Author

We can close this issue now.

@andreyvelich
Copy link
Member

Thank you for working on release @kannon92 🎉

@ahg-g
Copy link
Contributor

ahg-g commented Feb 28, 2025

Wonderful! we still need to update the docs :)

@ahg-g
Copy link
Contributor

ahg-g commented Feb 28, 2025

https://jobset.sigs.k8s.io/docs/installation/ still points to 0.7.2

@kannon92
Copy link
Contributor Author

https://jobset.sigs.k8s.io/docs/installation/ still points to 0.7.2

#808

@ahg-g
Copy link
Contributor

ahg-g commented Feb 28, 2025

Tried to install via the released helm chart, I get the following error:

ahg@ahg-cloudtop:~/helm$ ./helm install kueue oci://us-central1-docker.pkg.dev/k8s-staging-images/charts/jobset --version="v0.8.0" --create-namespace --namespace=jobset-system
Pulled: us-central1-docker.pkg.dev/k8s-staging-images/charts/jobset:v0.8.0
Digest: sha256:e1f25f53ba4312f99bb60b92668d98104c549067d86756d30cbf1cf18f2b47f7
Error: INSTALLATION FAILED: Unable to continue with install: MutatingWebhookConfiguration "jobset-mutating-webhook-configuration" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "kueue"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "jobset-system"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants