Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release jobset 0.8.0 for images and charts #7834

Merged
merged 1 commit into from
Feb 28, 2025
Merged

release jobset 0.8.0 for images and charts #7834

merged 1 commit into from
Feb 28, 2025

Conversation

kannon92
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Feb 26, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2025
@kannon92
Copy link
Contributor Author

cc @tenzen-y @mimowo @ahg-g

We may want to consider a different structure for helm charts as I think its a bit odd that Kueue maintainers have to approve all charts.

@kannon92 kannon92 mentioned this pull request Feb 26, 2025
Closed
20 tasks
@tenzen-y
Copy link
Member

cc @tenzen-y @mimowo @ahg-g

We may want to consider a different structure for helm charts as I think its a bit odd that Kueue maintainers have to approve all charts.

We evaluated other directory structures in https://docs.google.com/document/d/1xa2me_O0N5sHMD_np9ztr2O9GL3uX1yKBgDcApDqV_8/edit?usp=sharing&resourcekey=0-JHI0r4CeitKdIEJII7c8eg. But described in the documents, we saw some drawbacks.

We are open to changing directory structures if you have any other better ideas.

tenzen-y
tenzen-y reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve from Chart PoV

/assign @ahg-g

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 26, 2025
@ahg-g
Copy link
Member

ahg-g commented Feb 26, 2025

Is this ready for review?

@tenzen-y
Copy link
Member

Is this ready for review?

Kevin is currently trying to fix this weird container image endpoints: #7834 (comment)

@kannon92 kannon92 mentioned this pull request Feb 27, 2025
Merged
@kannon92
Copy link
Contributor Author

I am waiting for the images to be built and then I'll update this PR again.

@kannon92
Copy link
Contributor Author

Helm charts look better.

kehannon@kehannon-thinkpadp1gen4i:~/Work/admin-jobset$ helm template oci://us-central1-docker.pkg.dev/k8s-staging-images/charts/jobset --version v0.8.0 | grep image:
Pulled: us-central1-docker.pkg.dev/k8s-staging-images/charts/jobset:v0.8.0
Digest: sha256:e1f25f53ba4312f99bb60b92668d98104c549067d86756d30cbf1cf18f2b47f7
        image: "registry.k8s.io/jobset/jobset:v0.8.0"

this is ready for review/approval @tenzen-y @ahg-g.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@kannon92 kannon92 requested a review from tenzen-y February 27, 2025 21:50
tenzen-y
tenzen-y reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
from Helm PoV

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahg-g
Copy link
Member

ahg-g commented Feb 28, 2025

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6a33d3a into kubernetes:main Feb 28, 2025
3 of 4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 28, 2025
@kannon92 kannon92 mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@danielvegamyhre danielvegamyhre Awaiting requested review from danielvegamyhre

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@kannon92 @tenzen-y @ahg-g @k8s-ci-robot