Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jobset off of gcr #7820

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Migrate jobset off of gcr #7820

merged 1 commit into from
Feb 28, 2025

Conversation

kannon92
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2025
@k8s-ci-robot k8s-ci-robot added area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2025
@ahg-g
Copy link
Member

ahg-g commented Feb 24, 2025

An admin needs to actually trigger the migration, I don't think merging this PR will, we can merge it after the actual migration happens.

@upodroid
Copy link
Member

Can you amend your CI pipelines to publish to the updated staging registries and also update the image-pushing job like this?

@kannon92
Copy link
Contributor Author

Can you amend your CI pipelines to publish to the updated staging registries and also update the image-pushing job like this?

Looking at jobset image-pushing it seems it is already set to the right values.

@kannon92
Copy link
Contributor Author

CI was updated here.

@kannon92
Copy link
Contributor Author

I think this is good to merge.

The CI published to staging and we updated test-infra.

@kannon92
Copy link
Contributor Author

/retest

@kannon92
Copy link
Contributor Author

Hey @upodroid,

We merged #7834 and I am not seeing the jobset image promoted.

kehannon@kehannon-thinkpadp1gen4i:~/Work/test-infra$ podman pull registry.k8s.io/jobset/jobset:v0.8.0
Trying to pull registry.k8s.io/jobset/jobset:v0.8.0...
Error: initializing source docker://registry.k8s.io/jobset/jobset:v0.8.0: reading manifest v0.8.0 in registry.k8s.io/jobset/jobset: manifest unknown: Failed to fetch "v0.8.0"kehannon@kehannon-thinkpadp1gen4i:~/Work/test-infra$ podman pull registry.k8s.io/jobset/jobset:v0.8.0
Trying to pull registry.k8s.io/jobset/jobset:v0.8.0...
Error: initializing source docker://registry.k8s.io/jobset/jobset:v0.8.0: reading manifest v0.8.0 in registry.k8s.io/jobset/jobset: manifest unknown: Failed to fetch "v0.8.0"

Image exists in the staging repo so I'm not sure if something went wrong with promotion.

@kannon92
Copy link
Contributor Author

time="05:17:37.256" level=error msg="edge {{gcr.io/k8s-staging-jobset   true} {jobset v0.8.0} sha256:ad87d7473051593ab6419c464f17641ed91607721a7dd841d5be5534b1faf3d2 {europe-west8-docker.pkg.dev/k8s-artifacts-prod/images/jobset k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {jobset v0.8.0}}: skipping gcr.io/k8s-staging-jobset/jobset@sha256:ad87d7473051593ab6419c464f17641ed91607721a7dd841d5be5534b1faf3d2 because it is _LOST_ (can't find it in src registry!)\n" diff=0s

I think I need this PR as the promoter image is going to old gcr repo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 237beca into kubernetes:main Feb 28, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants