Fix helm charts having wrong repository name #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
|
/hold testing this. |
k8s-ci-robot
added
the
do-not-merge/hold
kannon92
force-pushed
the
fix-helm-images
branch
from
b130964 to
8e88335
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
ChenYi015
reviewed
Feb 27, 2025
kannon92
force-pushed
the
fix-helm-images
branch
2 times, most recently
from
76f024b to
e61283d
Compare
kannon92
force-pushed
the
fix-helm-images
branch
from
e61283d to
a087f48
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Should we recreate the 0.8 branch since we merged a few PRs since that one was cut? |
|
I did update the branch. I had one PR merge for websits so I don't really want to delete it now. /cherry-pick release-0.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Published helm charts to staging had an invalid chart repo.
This should hopefully fix this.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The RCA for kubernetes/k8s.io#7834 is that the default options for values were wrong. So it was putting the wrong defaults in when we published the chart.
The artifacts seem good actually but the default substitution was odd in the artifact registry.
I was able to test this by doing
make artifacts, unpacking the helm chart and runninghelm template. This will give you the yaml that helm renders so I was able to confirm the registry looks good.Does this PR introduce a user-facing change?