fix: Fix handling for multiple Daemonset nodeAffinity selectorTerms #1727
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Pull Request Test Coverage Report for Build 11130811960Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| func (p *Preferences) removePreferredNodeAffinityTerm(pod *v1.Pod) *string { | ||
| func (p *Preferences) RemovePreferredNodeAffinityTerm(pod *v1.Pod) *string { |
There was a problem hiding this comment.
Why export all these functions?
|
Hey @jonathan-innis any update on the following PR we are really waiting for this fix to land so we can use karpenter on our clusters currently this is a huge blocked for us |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
github-actions
bot
added
the
lifecycle/stale
|
Would love to see this get merged as well @jonathan-innis. |
github-actions
bot
removed
the
lifecycle/stale
Fixes #1337
Description
This change ensures that we consider all nodeAffinity terms when determining if the DS is going to schedule to the node.
How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.