Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: add ipv6 only global option #11831

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

network: add ipv6 only global option #11831

wants to merge 3 commits into from

Conversation

borislitv
Copy link

@borislitv borislitv commented Dec 25, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support ipv6 only clusters

Which issue(s) this PR fixes:
Fixes #5649

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 25, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 25, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @borislitv!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @borislitv. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 25, 2024
@yankay
Copy link
Member

yankay commented Dec 26, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 26, 2024
MrFreezeex
MrFreezeex suggested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, the initiative looks great. I left a few comments on possible improvements to improve readability though.

roles/kubernetes/control-plane/templates/kubeadm-config.v1beta3.yaml.j2 Outdated Show resolved Hide resolved
roles/container-engine/cri-dockerd/templates/cri-dockerd.service.j2 Outdated Show resolved Hide resolved
roles/kubernetes/control-plane/tasks/kubeadm-setup.yml Outdated Show resolved Hide resolved
roles/kubernetes/control-plane/tasks/kubeadm-setup.yml Show resolved Hide resolved
roles/kubespray-defaults/defaults/main/main.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 16, 2025
@borislitv borislitv requested a review from MrFreezeex January 16, 2025 08:04
@MrFreezeex
Copy link
Member

/label ci/extended

@k8s-ci-robot
Copy link
Contributor

@MrFreezeex: The label(s) /label ci/extended cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ci/extended

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MrFreezeex
Copy link
Member

/label ci-extended

@k8s-ci-robot k8s-ci-robot added the ci-extended Run additional tests label Jan 16, 2025
MrFreezeex
MrFreezeex approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/release-note-edit

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@MrFreezeex
Copy link
Member

/retest

@MrFreezeex
Copy link
Member

/release-note-edit

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

@k8s-ci-robot
Copy link
Contributor

@MrFreezeex: /release-note-edit must be used with a release note block.

In response to this:

/release-note-edit

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MrFreezeex
Copy link
Member

/release-note-edit

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 16, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@borislitv
Copy link
Author

Sorry, I had to add a small fix.
I found that ansible_default_ipv4 and ansible_default_ipv6 always available in hostvars, but may be '{}'

@borislitv borislitv requested a review from MrFreezeex January 16, 2025 12:27
MrFreezeex
MrFreezeex approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks for the additional fix!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: borislitv, MrFreezeex
Once this PR has been reviewed and has the lgtm label, please assign floryut for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@borislitv
Copy link
Author

/assign @floryut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@mzaian mzaian Awaiting requested review from mzaian

Assignees

@MrFreezeex MrFreezeex

@floryut floryut

Labels
ci-extended Run additional tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When can we expect ipv6-only support ?
5 participants
@borislitv @k8s-ci-robot @yankay @MrFreezeex @floryut