Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi-Kueue support to AppWrapper integration #3992

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dgrove-oss
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds multikueue adapter to appwrappers integration.

Which issue(s) this PR fixes:

Fixes #3989

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgrove-oss
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2025
@dgrove-oss dgrove-oss marked this pull request as draft January 17, 2025 02:27
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 1502079
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/678ad66509760800087d59d4

@mimowo
Copy link
Contributor

mimowo commented Jan 17, 2025

/cc @mszadkow for a review pass who is working recently on the integration for KubeRay

@k8s-ci-robot k8s-ci-robot requested a review from mszadkow January 17, 2025 10:05
@k8s-ci-robot
Copy link
Contributor

@mimowo: GitHub didn't allow me to request PR reviews from the following users: a, review, pass, who, on, the, KubeRay, is, working, recently, for.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mszadkow for a review pass who is working recently on the integration for KubeRay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mszadkow
Copy link
Contributor

Remember to add to list of supported prebuiltWorkloads in validation.go

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2025
@dgrove-oss dgrove-oss changed the title Add Multi-Kueue support to AppWrapperi integration Add Multi-Kueue support to AppWrapper integration Jan 17, 2025
@dgrove-oss dgrove-oss marked this pull request as ready for review January 17, 2025 20:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y January 17, 2025 20:58
@dgrove-oss
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@dgrove-oss
Copy link
Contributor Author

dgrove-oss commented Jan 17, 2025

I think to implement the proper managedBy defaulting for AppWrapper, I need to stop using the job framework's default webhook and switch back to a custom one (as in Job and JobSet) that include the managed by logic.

Is this the right approach, or should I look to generalize the base webhook so that it can incorporate optionally setting managedBy via an extension of GenericJob API? Perhaps by defining a JobWithManagedBy interface that had setters and getters

@k8s-ci-robot
Copy link
Contributor

@dgrove-oss: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-multikueue-e2e-main 1502079 link true /test pull-kueue-test-multikueue-e2e-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement multi-kueue adapter for appwrapper integration
4 participants