-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multi-Kueue support to AppWrapper integration #3992
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dgrove-oss The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/cc @mszadkow for a review pass who is working recently on the integration for KubeRay |
@mimowo: GitHub didn't allow me to request PR reviews from the following users: a, review, pass, who, on, the, KubeRay, is, working, recently, for. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Remember to add to list of supported prebuiltWorkloads in validation.go |
/hold |
I think to implement the proper Is this the right approach, or should I look to generalize the base webhook so that it can incorporate optionally setting managedBy via an extension of GenericJob API? Perhaps by defining a |
@dgrove-oss: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds multikueue adapter to appwrappers integration.
Which issue(s) this PR fixes:
Fixes #3989
Special notes for your reviewer:
Does this PR introduce a user-facing change?