-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stand alone pod annotation check in pod webhook #4109
base: main
Are you sure you want to change the base?
add stand alone pod annotation check in pod webhook #4109
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BenHinthorne The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @BenHinthorne. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
This PR adds a check for a "kueue.x-k8s.io/standalone" annotation on plain pods. If this annotation exists, then these pods will be suspended even if their ownerReference is a known integration to Kueue.
Only a draft for now.
What this PR does / why we need it:
At a high level, this would give users more flexibility to process plain pods with Kueue. Currently, users are blocked from allowing Kueue to process any pods that are owned by a known integration to Kueue.
For example, in Spark Apps, the Driver Pod is the Owner of the Executor pods. This prevents the Executor pods from being processed by Kueue at all, because the pod_webhook sees that they are owned by a resource of "Kind: Pod". With this annotation, users would be able to process these executors as plain pods. See the linked issue for more details.
Which issue(s) this PR fixes:
Fixes # #4106
Special notes for your reviewer:
Does this PR introduce a user-facing change?