-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: TAS: Use TAS implicitly when CQ is TAS-only #4519
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
3f4c895
to
4d7afb2
Compare
4d7afb2
to
4d7e773
Compare
/test pull-kueue-test-e2e-main-1-31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not reviewed detailed, yet.
But, let me add a question. How to notice to users that the workload is scheduled by TAS? I think it is matter since implicitly behavior should inform to users.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3754
Special notes for your reviewer:
WIP because I'm still revisiting the code myself, and should add an integration test, but early feedback is welcome.
Does this PR introduce a user-facing change?