Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: TAS: Use TAS implicitly when CQ is TAS-only #4519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Mar 7, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3754

Special notes for your reviewer:

WIP because I'm still revisiting the code myself, and should add an integration test, but early feedback is welcome.

Does this PR introduce a user-facing change?

Use TAS for workloads implicitly (without TAS annotations) when the target CQ is TAS-only, meaning
all the resource flavors have spec.topologyName specified. The implied behavior is as for the "preferred" 
annotation pointing to the lowest topology level.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2025
Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 4d7e773
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67cb25b069b4660008d83896

@mimowo mimowo force-pushed the tas-kueue-defaulting branch from 3f4c895 to 4d7afb2 Compare March 7, 2025 16:12
@mimowo mimowo force-pushed the tas-kueue-defaulting branch from 4d7afb2 to 4d7e773 Compare March 7, 2025 16:58
@mimowo
Copy link
Contributor Author

mimowo commented Mar 7, 2025

/test pull-kueue-test-e2e-main-1-31
Opened #4520

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed detailed, yet.
But, let me add a question. How to notice to users that the workload is scheduled by TAS? I think it is matter since implicitly behavior should inform to users.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TAS: reduce friction by defaulting the PodSet annotations
3 participants