Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #151: bump k8s version #164: pass in cloud config file path #205: Bump dependencies to v1.21.0 #308: Add tagging controller configuration #334: Stop retrying failed workitem after a certain amount of #362

Conversation

saurav-agarwalla
Copy link
Contributor

Cherry pick of #151 #164 #205 #308 #334 on release-1.19.

#151: bump k8s version
#164: pass in cloud config file path
#205: Bump dependencies to v1.21.0
#308: Add tagging controller configuration
#334: Stop retrying failed workitem after a certain amount of

For details on the cherry pick process, see the cherry pick requests page.


nicolehanjing and others added 30 commits May 12, 2022 00:13
* Move to NewCloudControllerManagerCommand to remove copy/paste template
  code, we don't do anything too special here that requires
  duplication of the command creation.
* Remove route controller again

* Print out clusterName for new nodes

* tag new nodes when it comes online

* only process a node once

* check taggNodes size

* add debugging

* use node name as key

* delete k,v from taggedNodes if node no longer exists

* log if delete is done

* Get a list of nodes and tag them if havent

* get instance IDs of the nodes that need tagging

* use MapToAWSInstanceID instead

* restored v1 aws

* restored from master

* tag instance with a random tag

* add klog

* tag and untag node resources

* Prepare for pr

* Initialize nodeMap
* get user input for resources

* Add better testing for failures to add flags

* fix a small issue with --resources

* finalize the --resources
@k8s-ci-robot
Copy link
Contributor

@saurav-agarwalla: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 12, 2022
@k8s-ci-robot
Copy link
Contributor

@saurav-agarwalla: This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @saurav-agarwalla. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saurav-agarwalla
To complete the pull request process, please assign m00nf1sh after the PR has been reviewed.
You can assign the PR to them by writing /assign @m00nf1sh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saurav-agarwalla
Copy link
Contributor Author

This is WIP. Running into some issues when trying to build this so will add more commits to fix them.

@saurav-agarwalla
Copy link
Contributor Author

Will work on 1.19 later hence closing this for now.

@saurav-agarwalla saurav-agarwalla deleted the automated-cherry-pick-of-#151-#164-#205-#308-#334-upstream-release-1.19 branch June 22, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants