Automated cherry pick of #308: Add tagging controller configuration #334: Stop retrying failed workitem after a certain amount of #387: Fix issues in tagging controller #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
Hi @saurav-agarwalla. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
add log rearrange the controllers remove debugging log removed route controller added a blank test file for the tagging controller remove predefined tag Refactoring based on recommendations Sticking to the naming convention address more comments on naming Using ListNode to get nodes entering and leaving the cluster. * Remove route controller again * Print out clusterName for new nodes * tag new nodes when it comes online * only process a node once * check taggNodes size * add debugging * use node name as key * delete k,v from taggedNodes if node no longer exists * log if delete is done * Get a list of nodes and tag them if havent * get instance IDs of the nodes that need tagging * use MapToAWSInstanceID instead * restored v1 aws * restored from master * tag instance with a random tag * add klog * tag and untag node resources * Prepare for pr * Initialize nodeMap refactor Add testing and controller config skeletons Added tagging and flags mechanisms Disabled the tagging controller by default Updated test structure Making the tests more robust Renaming the maps in tagging controller Refactoring names and remove debugging logs Add failure test cases for when EC2 return error adding details for --resources * get user input for resources * Add better testing for failures to add flags * fix a small issue with --resources * finalize the --resources add in Copyright message Using NodeInformer and Workqueue for tagging resources Used workqueue for both tag and untag actions Update docs/tagging_controller.md Co-authored-by: Nicholas Turner <[email protected]> Renamed fields in the tagging controller to be more user friendly Added in a loop to make sure all messages are processed before shutting down Added more logging Added more testing cosmetic change use array instead of map for supported resources Reworked the workqueue with workitem Addressed comments addressed verify-lint errors addressed comments and verify-lint address validate-lint error missed a couple more lint errors Updated doc to be clearer Add TODOs for e2e testing and non-retryable workitem Stop retrying failed workitem after a certain amount of retries Added metrics
…des to prevent retagging them again * Increase bucket size for latency metrics
saurav-agarwalla
force-pushed
the
automated-cherry-pick-of-#308-#334-#387-upstream-release-1.23
branch
from
580c009 to
aa33407
Compare
|
/assign @hakman |
|
/triage accepted |
k8s-ci-robot
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
saurav-agarwalla
deleted the
automated-cherry-pick-of-#308-#334-#387-upstream-release-1.23
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #308 #334 #387 on release-1.23.
#308: Add tagging controller configuration
#334: Stop retrying failed workitem after a certain amount of
#387: Fix issues in tagging controller
For details on the cherry pick process, see the cherry pick requests page.