Remove unused code

[panslava]

/assign @aojea

This shouldn't change any public interfaces, or any functionality, just never used code removed

[k8s-ci-robot]

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: panslava
Once this PR has been reviewed and has the lgtm label, please ask for approval from aojea. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[panslava]

/test cloud-provider-gcp-verify-up-to-date

[aojea]

it fails to compile now, hence the jobs are failing, you may need to run gazelle or some of the update scripts

[panslava]

oh I accidentally commited next work, that was not supposed to go in this commit, fixing

[bowei]

was this done using static analysis?

[panslava]

@bowei yes, I used golangci-lint "unused" linter, I can add it to the repo

[aojea]

if you remove flags, independently they maybe a noop, the manifests using this binary need to be updated or will fail to execute

[aojea]

I'm not much of a fun of removing code that is unused just because of that, it is not we are charged by number of lines and there is always something that may go wrong ... do we really need to take this risk?

[panslava]

yeh, tbh, initially I thought that would help me for further stuff, but not really

I remade this pr and ran linter with slightly softer (or stricter lol) rules so now I removed code that should not break anything. Also added linter config

but wouldn't say it's really needed, so feel free to ignore and close

[bowei]

We should try to delete dead code (otherwise when we will do that?) but flags we need to mark as deprecated or whatnot and keep for a while.

[panslava]

okay then

1. brought back removing all the code that seems to be unused
2. Deprecated the autopilot flag, but didn't remove

[aojea]

do we lose coverage?

we were running the linters before AFAIK as part of https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/cloud-provider-gcp/755/cloud-provider-gcp-verify-all/1828578606167625728

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.