Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2008: Graduate "Forensic Container Checkpointing" to GA #5090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-node/2008.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ alpha:
approver: "@ehashman"
beta:
approver: "@deads2k"
stable:
approver: "@deads2k"
18 changes: 16 additions & 2 deletions keps/sig-node/2008-forensic-container-checkpointing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,11 @@ extending the production code to implement this enhancement.
- `pkg/kubelet/container`: 02-08-2024 - 55.7
- `pkg/kubelet/server`: 02-08-2024 - 65.1
- `pkg/kubelet/cri/remote`: 02-08-2024 - 18.9
- Test coverage before GA graduation
- `pkg/kubelet`: 01-27-2025 - 70.6
- `pkg/kubelet/container`: 01-08-2025 - 52.9
- `pkg/kubelet/server`: 01-27-2025 - 64.9
- `staging/src/k8s.io/cri-client/pkg`: 01-27-2025 - 38.2

##### Integration tests

Expand Down Expand Up @@ -354,6 +359,14 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
features enabled with CRI-O, no results have been collected and tests have
been skipped.

- Since the release of containerd 2.0 and CRI-O 1.25 and since the graduation of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyKanzhelev @mikebrow @samuelkarp do you think containerd 2.0 is new enough to consider the checkpoint CRI API GA?

Forensic Container Checkpointing to Beta, end to end tests are being run:
<https://storage.googleapis.com/k8s-triage/index.html?test=checkpoint#a3361808c39a7eb28162>
Looking at the results today (2025-01-27) the only error seems to have been
on 2025-01-16 using containerd as well as CRI-O. Looking at the log files of the
failed tests the failure was also seen with other tests which indicates that
this failure was not related to the Forensic Container Checkpointing feature.

### Graduation Criteria

#### Alpha
Expand Down Expand Up @@ -388,12 +401,12 @@ In Kubernetes:
CRI-O as well as containerd have to have implemented the corresponding CRI APIs:

- [x] CRI-O
- [x] containerd (<https://github.com/containerd/containerd/pull/6965>)
- [x] containerd

Ensure that e2e tests are working with

- [x] CRI-O
- [x] containerd (<https://github.com/containerd/containerd/pull/6965>)
- [x] containerd

### Upgrade / Downgrade Strategy

Expand Down Expand Up @@ -681,6 +694,7 @@ that can be turned off during startup or runtime configuration.
* 2022-04-05: Added CRI API section and targeted 1.25
* 2022-05-17: Remove *restore* RPC from the CRI API
* 2024-02-08: Graduation to Beta.
* 2025-01-27: Graduation to GA.

## Drawbacks

Expand Down
6 changes: 3 additions & 3 deletions keps/sig-node/2008-forensic-container-checkpointing/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@ participating-sigs:
- TBD
status: implementable
creation-date: 2020-09-16
last-updated: 2024-02-08
last-updated: 2025-02-27
reviewers:
- "@mrunalp"
- "@elfinhe"
approvers:
- "@dchen1107"

# The target maturity stage in the current dev cycle for this KEP.
stage: beta
stage: stable

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.30"
latest-milestone: "v1.33"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
Expand Down