Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-provider-gcp: periodically publish cloud-controller-manager image #27730

Conversation

andrewsykim
Copy link
Member

Signed-off-by: Andrew Sy Kim [email protected]

Temporarily add a 4h periodic job to publish cloud-controller-manager image from k8s.io/cloud-provider-gcp. I intend to eventually move this to a postsubmit trigger but using a periodic job for testing purposes now.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewsykim
Once this PR has been reviewed and has the lgtm label, please assign jprzychodzen for approval by writing /assign @jprzychodzen in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 11, 2022
export GO111MODULE=on;
export BAZEL_VERSION=5.3.0;
/workspace/test-infra/images/kubekins-e2e/install-bazel.sh;
bazel run //cmd/cloud-controller-manager:publish
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should publish something like this:

registry.k8s.io/k8s-image-staging/cloud-controller-manager:v1.25.2-alpha_ae91c1fc0c443c464a4c878ffa2a4544483c6d1f

I have not been able to validate whether the existing prow jobs for cloud-provider-gcp have access to push to this registry, but figured just trying to run the job is the best way to find out :

@andrewsykim
Copy link
Member Author

/close

I'm going to re-open this after doing more testing (requires a separate PR for ACLs)

@k8s-ci-robot
Copy link
Contributor

@andrewsykim: Closed this PR.

In response to this:

/close

I'm going to re-open this after doing more testing (requires a separate PR for ACLs)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jprzychodzen
Copy link
Contributor

@andrewsykim What's the status on this? Can we reopen and merge this? I've generated similar PR and I think it would be great if we could continue with it and wrap up kubernetes/cloud-provider-gcp#289

@andrewsykim
Copy link
Member Author

/reopen

(we should rebase this off of work in kubernetes/cloud-provider-gcp#377)

@k8s-ci-robot
Copy link
Contributor

@andrewsykim: Failed to re-open PR: state cannot be changed. There is already an open pull request from andrewsykim:cloud-provider-gcp-periodic-publish to kubernetes:master.

In response to this:

/reopen

(we should rebase this off of work in kubernetes/cloud-provider-gcp#377)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants