-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-provider-gcp: periodically publish cloud-controller-manager image #27730
cloud-provider-gcp: periodically publish cloud-controller-manager image #27730
Conversation
Signed-off-by: Andrew Sy Kim <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrewsykim The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
export GO111MODULE=on; | ||
export BAZEL_VERSION=5.3.0; | ||
/workspace/test-infra/images/kubekins-e2e/install-bazel.sh; | ||
bazel run //cmd/cloud-controller-manager:publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should publish something like this:
registry.k8s.io/k8s-image-staging/cloud-controller-manager:v1.25.2-alpha_ae91c1fc0c443c464a4c878ffa2a4544483c6d1f
I have not been able to validate whether the existing prow jobs for cloud-provider-gcp have access to push to this registry, but figured just trying to run the job is the best way to find out :
/close I'm going to re-open this after doing more testing (requires a separate PR for ACLs) |
@andrewsykim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andrewsykim What's the status on this? Can we reopen and merge this? I've generated similar PR and I think it would be great if we could continue with it and wrap up kubernetes/cloud-provider-gcp#289 |
/reopen (we should rebase this off of work in kubernetes/cloud-provider-gcp#377) |
@andrewsykim: Failed to re-open PR: state cannot be changed. There is already an open pull request from andrewsykim:cloud-provider-gcp-periodic-publish to kubernetes:master. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Andrew Sy Kim [email protected]
Temporarily add a 4h periodic job to publish
cloud-controller-manager
image fromk8s.io/cloud-provider-gcp
. I intend to eventually move this to a postsubmit trigger but using a periodic job for testing purposes now.