DRA: support multiple alpha features #34231
Conversation
The kind-dra-all jobs only worked for a single additional alpha feature, the first one, because the shell for loop for the array variable wasn't quite right. Let's try in a canary job first, then promote the fix.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
|
Needed for kubernetes/kubernetes#128586 (comment) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -71,7 +71,7 @@ | |||
| {%- endif %} | |||
| spec: | |||
| containers: | |||
| - image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20241230-3006692a6f-master | |||
| - image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250121-4aed057712-master | |||
There was a problem hiding this comment.
Theoretically this change should conflict with master, but it doesn't for some reason. Any idea why?
There was a problem hiding this comment.
Because it's bumping to the exact same version that is also used by master? git merge is smart enough to handle such cases.
There was a problem hiding this comment.
I could rebase to make this diff go away, but prefer not to. This won't occur in the future once #34235 keeps dra.jinja up-to-date.
Adding a new job can still be problematic if the PR with the new job goes stale and the image gets bumped in the meantime.
The kind-dra-all jobs only worked for a single additional alpha feature, the first one, because the shell for loop for the array variable wasn't quite right.
Let's try in a canary job first, then promote the fix.
/assign @bart0sh
/cc @mortent