Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new gcsweb directory download instructions #34400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omertuc
Copy link
Contributor

@omertuc omertuc commented Feb 24, 2025

See 77eee46 (#26978) for context

This commit updates the instructions to also suggest the gcloud storage CLI instead of just the gsutil CLI. The gsutil CLI seems like it's losing support? It doesn't work on Python 3.13 anymore and it doesn't seem clear when it will.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2025
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @omertuc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omertuc
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omertuc omertuc force-pushed the gcloud branch 2 times, most recently from 8dee1c4 to 2f58b28 Compare February 24, 2025 12:37
@smg247
Copy link
Contributor

smg247 commented Feb 24, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2025
@omertuc
Copy link
Contributor Author

omertuc commented Feb 24, 2025

Force pushed only to change the commit messages due to typos

@smg247
Copy link
Contributor

smg247 commented Feb 24, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2025
See 77eee46 (kubernetes#26978) for context

This commit updates the instructions to also suggest the `gcloud
storage` CLI instead of just the `gsutil` CLI. The `gsutil` CLI seems
like it's losing support? It doesn't work on Python 3.13 anymore and it
doesn't seem clear when it will.

Signed-off-by: Omer Tuchfeld <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2025
@omertuc
Copy link
Contributor Author

omertuc commented Feb 24, 2025

Forced push to fix unit-test

@smg247
Copy link
Contributor

smg247 commented Feb 27, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants