-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new gcsweb directory download instructions #34400
base: master
Are you sure you want to change the base?
Conversation
Hi @omertuc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8dee1c4
to
2f58b28
Compare
/lgtm |
Force pushed only to change the commit messages due to typos |
/ok-to-test |
See 77eee46 (kubernetes#26978) for context This commit updates the instructions to also suggest the `gcloud storage` CLI instead of just the `gsutil` CLI. The `gsutil` CLI seems like it's losing support? It doesn't work on Python 3.13 anymore and it doesn't seem clear when it will. Signed-off-by: Omer Tuchfeld <[email protected]>
Forced push to fix unit-test |
/lgtm |
See 77eee46 (#26978) for context
This commit updates the instructions to also suggest the
gcloud storage
CLI instead of just thegsutil
CLI. Thegsutil
CLI seems like it's losing support? It doesn't work on Python 3.13 anymore and it doesn't seem clear when it will.