-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added swift example, moved PVC to bottom #34439
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hector-vido The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @hector-vido. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
aa95a23
to
6621a09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should actually be moving this folder to sigs.k8s.io/prow?
https://github.com/kubernetes-sigs/prow
The maintainers of that repo would be best equipped to make decisions about changes to docs for getting started with it, and that repo is a more appropriate place to host them, this is left over from when prow was contained within this repo instead of it's own repo, IMHO.
Swift
Despite the s3api on swift, is not very obvious how we should set the
endpoint
, I think this example can help not only people that are trying to deploy Prow inside Openstack but also any other "s3like
" person searching for some examples.I the variables with
OPENSTACK_EC2_CREDENTIALS_
to give clue about thecredentials
command:PersistentVolumeClaim
I also moved the
PersistentVolumeClaims
to the bottom, this way we cankubectl replace -f manifest.yaml
, and let thePVC
fail as the last command, when we don't want to create other files for each object.