Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added swift example, moved PVC to bottom #34439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hector-vido
Copy link

@hector-vido hector-vido commented Mar 1, 2025

Swift

Despite the s3api on swift, is not very obvious how we should set the endpoint, I think this example can help not only people that are trying to deploy Prow inside Openstack but also any other "s3like" person searching for some examples.

I the variables with OPENSTACK_EC2_CREDENTIALS_ to give clue about the credentials command:

openstack ec2 credentials create --user prow --project openshift

PersistentVolumeClaim

I also moved the PersistentVolumeClaims to the bottom, this way we can kubectl replace -f manifest.yaml, and let the PVC fail as the last command, when we don't want to create other files for each object.

Copy link

linux-foundation-easycla bot commented Mar 1, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hector-vido / name: Hector Vido (6621a09)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 1, 2025
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims March 1, 2025 13:37
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hector-vido
Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @hector-vido. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 1, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 1, 2025
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should actually be moving this folder to sigs.k8s.io/prow?

https://github.com/kubernetes-sigs/prow

The maintainers of that repo would be best equipped to make decisions about changes to docs for getting started with it, and that repo is a more appropriate place to host them, this is left over from when prow was contained within this repo instead of it's own repo, IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants