-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front page light and dark mode #45366
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@sftim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't match the change I'd expected to see
- The front page needs to be legible and accessible whether the user's browser wants a dark or light theme.
- We need to ensure good contrast between all text and its background.
- This change changes every page, not just the front page.
I would prefer to see a change that honors prefers-color-scheme
; there is no need for this PR to expose a user interface mechanism to override that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid that using the browser's automatic dark mode adaptation does not count as addressing the associated issue. This is about changing the site (specifically, protoyping with the front page), to render appropriately when a user agent says that the user prefers a dark theme.
@tamilselvan1102 if you'd like some more detailed feedback, message me directly on Kubernetes Slack and I'll see about a time slot for that (might have to be late March or April, I'm afraid). |
layouts/partials/scripts.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any change to this file is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the wrong place to make changes; look in assets/scss
instead.
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
/close |
@tamilselvan1102: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #37444