Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front page light and dark mode #45366

Closed

Conversation

tamilselvan1102
Copy link

Fixes #37444

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Feb 27, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 89621a3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65f18404225e320009696b14
😎 Deploy Preview https://deploy-preview-45366--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tamilselvan1102
Copy link
Author

@tamilselvan1102
Copy link
Author

@sftim
please review the changes

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't match the change I'd expected to see

  • The front page needs to be legible and accessible whether the user's browser wants a dark or light theme.
    • We need to ensure good contrast between all text and its background.
  • This change changes every page, not just the front page.

I would prefer to see a change that honors prefers-color-scheme; there is no need for this PR to expose a user interface mechanism to override that.

layouts/partials/navbar.html Outdated Show resolved Hide resolved
@tamilselvan1102
Copy link
Author

tamilselvan1102 commented Feb 28, 2024

@sftim
Current CSS it self, dark mode is working fine. attached the evidence taken from chrome.
If you want to change colorings in any section in dark mode, i will do it
dark.pdf

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that using the browser's automatic dark mode adaptation does not count as addressing the associated issue. This is about changing the site (specifically, protoyping with the front page), to render appropriately when a user agent says that the user prefers a dark theme.

@sftim
Copy link
Contributor

sftim commented Feb 28, 2024

@tamilselvan1102 if you'd like some more detailed feedback, message me directly on Kubernetes Slack and I'll see about a time slot for that (might have to be late March or April, I'm afraid).

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 6, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any change to this file is needed.

layouts/partials/css.html Outdated Show resolved Hide resolved
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the wrong place to make changes; look in assets/scss instead.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
Tamilselvan and others added 2 commits March 13, 2024 16:16
@tamilselvan1102
Copy link
Author

/close

@k8s-ci-robot
Copy link
Contributor

@tamilselvan1102: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow (auto)switching front page between light mode and dark mode
3 participants