Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Docsy to 0.7.x #48725

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Bump Docsy to 0.7.x #48725

wants to merge 11 commits into from
+986 −529

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Nov 14, 2024 •
edited
Loading

This PR upgrades to a newer version of Docsy: 0.7.2 (preview)

In the testing I've done, I haven't found any different look or behavior that still needs fixing. The top nav doesn't look right, though.

/area web-development

This PR incorporates the commits from:
This PR incorporates the commits from PRs:

@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 14, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 38c2fe6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67388596d5a40d0008ebda97
😎 Deploy Preview https://deploy-preview-48725--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim sftim mentioned this pull request Nov 14, 2024
Open
dipesh-rawat
dipesh-rawat reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the deploy preview (here), I noticed that the search query text in the navbar input box is currently invisible due to the text color being white.

@sftim sftim marked this pull request as draft November 15, 2024 11:10
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
@sftim
Copy link
Contributor Author

sftim commented Nov 15, 2024

Ah, this needs a fix!

@sftim sftim marked this pull request as ready for review November 16, 2024 11:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@salaxander salaxander Awaiting requested review from salaxander

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees
No one assigned
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sftim @k8s-ci-robot @dipesh-rawat