Fix: Set default values for traits in VelaUX #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am6737
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
- Coverage 59.01% 51.08% -7.94%
==========================================
Files 116 116
Lines 19846 16511 -3335
==========================================
- Hits 11713 8435 -3278
- Misses 6696 6833 +137
+ Partials 1437 1243 -194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wonderflow
approved these changes
Oct 8, 2024
barnettZQG
reviewed
Oct 9, 2024
| @@ -176,6 +177,32 @@ class UISchema extends Component<Props, State> { | |||
| }); | |||
| }; | |||
|
|
|||
| initFormValues = () => { | |||
There was a problem hiding this comment.
Why do we need to do this?
There was a problem hiding this comment.
Thanks for your feedback! I realized the issue and have updated the code accordingly.
Looking forward to your thoughts!
Added `setDefaultProperties` to ensure default values are correctly set for traits like "cpuscaler", "hpa", "resource", and "k8s-update-strategy". Signed-off-by: am6737 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #650
I have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer