Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt UEFI in Windows 2k12, 2k16 and 2k19 #570

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Adopt UEFI in Windows 2k12, 2k16 and 2k19 #570

merged 1 commit into from
Mar 12, 2024

Conversation

fossedihelm
Copy link
Contributor

Adopt UEFI in Windows 2k12, 2k16 and 2k19 by enabling EFI and Secureboot in the respective templates.

What this PR does / why we need it:
Adopt UEFI in Windows 2k12, 2k16 and 2k19 by enabling EFI and Secureboot in the respective templates.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Adopted UEFI in Windows 2k12, 2k16 and 2k19 by enabling EFI and Secureboot in the respective templates.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 4, 2024
@kubevirt-bot kubevirt-bot requested review from ksimon1 and lyarwood March 4, 2024 15:46
0xFelix
0xFelix reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

Please note: For e2e tests to pass the used images likely need to be updated to support EFI boot.

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@fossedihelm
Adopt UEFI in Windows 2k12, 2k16 and 2k19
8df2274 
Adopt UEFI in Windows 2k12, 2k16 and 2k19 by enabling EFI and Secureboot
in the respective templates.

Signed-off-by: fossedihelm <[email protected]>
@ksimon1
Copy link
Member

ksimon1 commented Mar 5, 2024

/lgtm
/approve
As Felix said, We will need new images, which supports EFI. If you can send me links to them, I can push them to correct places.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fossedihelm
Copy link
Contributor Author

/lgtm /approve As Felix said, We will need new images, which supports EFI. If you can send me links to them, I can push them to correct places.

👍 working on it! Thanks

@fossedihelm
Copy link
Contributor Author

/retest

@fossedihelm
Copy link
Contributor Author

/test e2e-gcp-common-templates-windows2016

@kubevirt-bot
Copy link
Contributor

@fossedihelm: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows2016

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fossedihelm
Copy link
Contributor Author

/retest

1 similar comment
@fossedihelm
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit 407f2cb into kubevirt:master Mar 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fossedihelm @ksimon1 @kubevirt-bot @0xFelix