Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makefile): Re-add missing generate target #658

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Dec 10, 2024

What this PR does / why we need it:

Re-add the missing generate target to the dist/common-templates.yaml target.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

None

Re-add the missing generate target to the dist/common-templates.yaml
target.

Signed-off-by: Felix Matouschek <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 10, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from 0xfelix. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@0xFelix 0xFelix merged commit cb52a11 into kubevirt:master Dec 10, 2024
2 of 18 checks passed
@0xFelix
Copy link
Member Author

0xFelix commented Dec 10, 2024

/cherry-pick release-v0.32

@0xFelix 0xFelix deleted the fix-dist-common-templates branch December 10, 2024 10:36
@kubevirt-bot
Copy link
Contributor

@0xFelix: new pull request created: #659

In response to this:

/cherry-pick release-v0.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants