-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config/manager, ipam-ext Deployment: Remove limits, Increase reqeusts #88
Conversation
Oh you need to run |
there is no
I did do |
Run |
CI tests fails.. weird. checking locally |
ah this is actually good news, it means that ovn-kubernetes/ovn-kubernetes#4854 was merged. |
control-plane components such as ipam-ext Deployment should not have memory/cpu limit. Signed-off-by: Ram Lavi <[email protected]>
Matching memory demand used by similar components like kubemacpool [0] [0] https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/config/release/kubemacpool.yaml#L301 Signed-off-by: Ram Lavi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maiqueb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
control-plane components such as ipam-ext Deployment should not have memory/cpu limit.
This PR removes the limits.
Also, Increasing memory request to those requested by similar components like kubemacpool.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: