Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/manager, ipam-ext Deployment: Remove limits, Increase reqeusts #88

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

RamLavi
Copy link
Contributor

@RamLavi RamLavi commented Jan 23, 2025

What this PR does / why we need it:
control-plane components such as ipam-ext Deployment should not have memory/cpu limit.
This PR removes the limits.
Also, Increasing memory request to those requested by similar components like kubemacpool.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 23, 2025
@RamLavi RamLavi changed the title config/manager: Remove ipam-ext Deployment limit config/manager: Remove ipam-ext Deployment limits Jan 23, 2025
@maiqueb
Copy link
Collaborator

maiqueb commented Jan 23, 2025

Oh you need to run make install and commit the changes you'll see in the deployment manifest.
Please make sure to define the variable with the IMG name.

@RamLavi RamLavi changed the title config/manager: Remove ipam-ext Deployment limits config/manager, ipam-ext Deployment: Remove limits, Increase reqeusts Jan 23, 2025
@RamLavi
Copy link
Contributor Author

RamLavi commented Jan 23, 2025

Oh you need to run make install and commit the changes you'll see in the deployment manifest. Please make sure to define the variable with the IMG name.

there is no make install:

ipam-extensions (remove_limit) $ make install
make: *** No rule to make target 'install'.  Stop.

I did do make build manifest - but it didn't seem to to anything, so I figured you don't save the manifest created by kustomize. is that the case? rechecking...

@maiqueb
Copy link
Collaborator

maiqueb commented Jan 23, 2025

Oh you need to run make install and commit the changes you'll see in the deployment manifest. Please make sure to define the variable with the IMG name.

there is no make install:

ipam-extensions (remove_limit) $ make install
make: *** No rule to make target 'install'.  Stop.

I did do make build manifest - but it didn't seem to to anything, so I figured you don't save the manifest created by kustomize. is that the case? rechecking...

Run IMG=ghcr.io/kubevirt/ipam-controller:latest make build-installer

@RamLavi
Copy link
Contributor Author

RamLavi commented Jan 23, 2025

CI tests fails.. weird. checking locally

@RamLavi
Copy link
Contributor Author

RamLavi commented Jan 23, 2025

CI tests fails.. weird. checking locally

ah this is actually good news, it means that ovn-kubernetes/ovn-kubernetes#4854 was merged.

control-plane components such as ipam-ext Deployment
should not have memory/cpu limit.

Signed-off-by: Ram Lavi <[email protected]>
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2025
@kubevirt-bot kubevirt-bot merged commit 05b47ce into kubevirt:main Jan 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants